From e072e896c7dc744147c38a7d36d9eedd413399fa Mon Sep 17 00:00:00 2001
From: Antoine Poinsot <darosior@protonmail.com>
Date: Sun, 8 Oct 2023 12:31:41 +0200
Subject: [PATCH] bitcoind: don't set load_on_startup when loading watchonly
 wallet

This was necessary to transition wallets that were created without this
flag, but since v2 they are always created with it so this is redundant:
it'd unnecessarily try to update the flag over and over again on
bitcoind's side, always with the same value.
---
 src/bitcoin/d/mod.rs | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/bitcoin/d/mod.rs b/src/bitcoin/d/mod.rs
index 3efbaa25..74f3ee56 100644
--- a/src/bitcoin/d/mod.rs
+++ b/src/bitcoin/d/mod.rs
@@ -652,10 +652,7 @@ impl BitcoinD {
         }
         let res = self.make_fallible_node_request(
             "loadwallet",
-            &params!(
-                Json::String(self.watchonly_wallet_path.clone()),
-                Json::Bool(true), // load_on_startup
-            ),
+            &params!(Json::String(self.watchonly_wallet_path.clone()),),
         );
         match res {
             Err(BitcoindError::Server(jsonrpc::Error::Rpc(ref e))) => {