Merge #1729: fix update wallet alias in wallet settings

546ac29587e831abbe79e66d23cac9683467a842 fix update wallet alias in wallet settings (edouardparis)

Pull request description:

  L522 the wallet was populated with its new alias
  and the check L567 was always false.

  wallet_alias is None if we do not have to update it, so better pass the variable directly.

ACKs for top commit:
  edouardparis:
    Self-ACK 546ac29587e831abbe79e66d23cac9683467a842

Tree-SHA512: 971e441eb67cdc20aea7e2631bf74b568ce216e2a4d86a292d5f6d04bcfef37c3180c2df2510a150bc13ef605ab60bea40a8a7e8683f020b01f84aae9dd08098

liana-gui/src/app/state/settings/wallet.rs

@@ -563,15 +563,7 @@ pub async fn update_aliases(
     wallet.keys_aliases = keys_aliases.into_iter().collect();
 
     daemon
-        .update_wallet_metadata(
-            if wallet_alias.is_some() && wallet.alias != wallet_alias {
-                wallet_alias
-            } else {
-                None
-            },
-            &wallet.keys_aliases,
-            &wallet.hardware_wallets,
-        )
+        .update_wallet_metadata(wallet_alias, &wallet.keys_aliases, &wallet.hardware_wallets)
         .await?;
 
     Ok(Arc::new(wallet))