Merge #602: bitcoind: set load_on_startup to true when loading watchonly wallet

23a63f35e1344a0e6c247e564311cac3e965693c bitcoind: override watchonly wallet as to be loaded on startup (Antoine Poinsot)

Pull request description:

  we used to not set 'load_on_startup' when creating a watchonly wallet. This could create some complications when people are using agressive pruning configurations.

  Fix this by overwriting this parameter when loading watchonly wallets. We can always revert this in the future if for some reason a user wants to have it set to false and no be overwritten everytime Liana loads it.

  Fixes #594.

ACKs for top commit:
  darosior:
    self-ACK 23a63f35e1344a0e6c247e564311cac3e965693c -- tested locally

Tree-SHA512: 8310918286a8a0102bfc76e9d5b2ba4a8b50cac3e4ce2fd26bdfae7c153eeba3bf516d70ed6ef6256c5f4bcc3955559c011a7035cbc293cc594b829ea9038a5c

src/bitcoin/d/mod.rs

@@ -646,7 +646,10 @@ impl BitcoinD {
         }
         let res = self.make_fallible_node_request(
             "loadwallet",
-            &params!(Json::String(self.watchonly_wallet_path.clone()),),
+            &params!(
+                Json::String(self.watchonly_wallet_path.clone()),
+                Json::Bool(true), // load_on_startup
+            ),
         );
         match res {
             Err(BitcoindError::Server(jsonrpc::Error::Rpc(ref e))) => {