nik/liana
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

send max from all owned coins only

Browse Source 
Coin selection considers only those unconfirmed coins from self,
and the same should apply when the user chooses the MAX option
without explicitly selecting coins.

Unconfirmed coins that are not from self should only be included
if the user has selected them explicitly.
This commit is contained in:
Michael Mallan 2024-12-20 14:40:13 +00:00
parent 021c8e2a43
commit e8d2fe2717
No known key found for this signature in database
GPG Key ID: 5177CDCEDB0EABEB
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
liana-gui/src/app/state/spend/step.rs
View File

@ -283,8 +283,11 @@ impl DefineSpend {
}
outpoints
} else if self.send_max_to_recipient.is_some() {
// If user has not selected coins, send the max available from all coins.
self.coins.iter().map(|(c, _)| c.outpoint).collect()
// If user has not selected coins, send the max available from all owned coins.
self.coins
.iter()
.filter_map(|(c, _)| coin_is_owned(c).then_some(c.outpoint))
.collect()
} else {
Vec::new() // pass empty list for auto-selection
};
@ -358,10 +361,9 @@ impl DefineSpend {
self.amount_left_to_select = Some(Amount::from_sat(missing));
if !self.is_user_coin_selection {
// The missing amount is based on all candidates for coin selection
// being used, which are all coins if there's a recipient with max
// or otherwise all owned coins.
// being used, which are all owned coins.
for (coin, selected) in &mut self.coins {
*selected = self.send_max_to_recipient.is_some() || coin_is_owned(coin);
*selected = coin_is_owned(coin);
}
}
if let Some((i, recipient)) = recipient_with_max {