Merge #1554: chore: fix some comments
f12c65cdd26f9b611b524b4f30c69bb4ad956c22 chore: fix some comments (damuzhi0810)
Pull request description:
fix some comments
ACKs for top commit:
jp1ac4:
ACK f12c65cdd26f9b611b524b4f30c69bb4ad956c22.
Tree-SHA512: 540abcc6d1faddb9f9b81f8dc5c7918daa4bb4bf7179276c768d49c18109283f45eb62734892ad9c40460bc07daa2001967bcbecb0de77335f308d627195930c
This commit is contained in:
commit
eae89211d1
@ -608,7 +608,7 @@ impl RescanSetting {
|
||||
return Command::none();
|
||||
}
|
||||
self.processing = true;
|
||||
info!("Asking deamon to rescan with timestamp: {}", t);
|
||||
info!("Asking daemon to rescan with timestamp: {}", t);
|
||||
return Command::perform(
|
||||
async move {
|
||||
daemon.start_rescan(t.try_into().expect("t cannot be inferior to 0 otherwise genesis block timestamp is chosen"))
|
||||
|
||||
@ -591,7 +591,7 @@ impl BitcoinInterface for electrum::Electrum {
|
||||
}
|
||||
}
|
||||
|
||||
// FIXME: do we need to repeat the entire trait implemenation? Isn't there a nicer way?
|
||||
// FIXME: do we need to repeat the entire trait implementation? Isn't there a nicer way?
|
||||
impl BitcoinInterface for sync::Arc<sync::Mutex<dyn BitcoinInterface + 'static>> {
|
||||
fn genesis_block_timestamp(&self) -> u32 {
|
||||
self.lock().unwrap().genesis_block_timestamp()
|
||||
|
||||
@ -49,7 +49,7 @@ impl DatabaseInterface for SqliteDb {
|
||||
}
|
||||
}
|
||||
|
||||
// FIXME: do we need to repeat the entire trait implemenation? Isn't there a nicer way?
|
||||
// FIXME: do we need to repeat the entire trait implementation? Isn't there a nicer way?
|
||||
impl DatabaseInterface for sync::Arc<sync::Mutex<dyn DatabaseInterface>> {
|
||||
fn connection(&self) -> Box<dyn DatabaseConnection> {
|
||||
self.lock().unwrap().connection()
|
||||
|
||||
@ -4,7 +4,7 @@
|
||||
//! > Multi-thread. In this mode, SQLite can be safely used by multiple threads provided that
|
||||
//! > no single database connection is used simultaneously in two or more threads.
|
||||
//!
|
||||
//! We leverage SQLite's `unlock_notify` feature to synchronize writes accross connection. More
|
||||
//! We leverage SQLite's `unlock_notify` feature to synchronize writes across connection. More
|
||||
//! about it at https://sqlite.org/unlock_notify.html.
|
||||
|
||||
pub mod schema;
|
||||
|
||||
@ -842,7 +842,7 @@ mod tests {
|
||||
// before checking the bitcoind sync status.
|
||||
t.join().unwrap();
|
||||
|
||||
// The datadir is created now, so if we restart it it won't create the wo wallet.
|
||||
// The datadir is created now, so if we restart, it won't create the wo wallet.
|
||||
let t = thread::spawn({
|
||||
let config = config.clone();
|
||||
move || {
|
||||
|
||||
@ -105,7 +105,7 @@ class Bitcoind(BitcoinBackend):
|
||||
|
||||
# wait_for_mempool can be used to wait for the mempool before generating
|
||||
# blocks:
|
||||
# True := wait for at least 1 transation
|
||||
# True := wait for at least 1 transaction
|
||||
# int > 0 := wait for at least N transactions
|
||||
# 'tx_id' := wait for one transaction id given as a string
|
||||
# ['tx_id1', 'tx_id2'] := wait until all of the specified transaction IDs
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user