3a30a36ce5f58e8ae2c92926384d76253e702894 gui: do not display hw error on simple user refusal (edouardparis)
Pull request description:
close#937
ACKs for top commit:
edouardparis:
Self-ACK 3a30a36ce5f58e8ae2c92926384d76253e702894
Tree-SHA512: c2c1aed212b9389bac62da17552daa6d87d0eeea6180ec19e37dd9ef4dd0faa935a621123df6306ef9ca6fadffba35c1c047d2906a9c15db3a14cd8ccf156e29
This change updates the GUI to support the latest lianad config
file with the user/password option for bitcoind RPC authentication.
The settings have been updated to set either cookie file path
or user and password.
The installer still only supports the cookie file and has only
been updated with the changes required to compile.
When starting, the internal bitcoind now looks for the cookie file
in the usual location rather than relying on the config file.
In case user clicks on Previous before bitcoind download has
finished, this will clear the incomplete download from
`InternalBitcoindStep` so that a new download will start if the
user returns to this step.
If a user clicked very fast a lot on the Next button
to trigger multiple Next messages, then the last
step of the install reloads multiple time.
This commit introduce a check that ignore next message
if the step is the last one.
This makes it possible to bump the managed bitcoind version used
when installing a new Liana wallet.
The GUI will look for the most recent managed bitcoind version
available when starting bitcoind so that existing wallets
with a previous managed bitcoind version will not be affected.
9895b493f1d79ae8fc5a1591ef455ccda2d81ccd gui: trim text input strings (jp1ac4)
d3f2931375ff95c201a60164bf1015f18c6e87ce gui: remove unused file (jp1ac4)
Pull request description:
This is to resolve#323.
Following suggestions in #323, I've added a new `TrimmedString` struct that takes a string and applies `trim()`. This type is then used as `form::Value<TrimmedString>` to ensure text inputs are trimmed.
I'm creating this PR as draft to check if this is the right approach before applying the change to other inputs.
I've also removed a view file that seems to have been created accidentally.
ACKs for top commit:
edouardparis:
ACK 9895b493f1d79ae8fc5a1591ef455ccda2d81ccd
Tree-SHA512: 76c7f28ed2d0b6b6b76658a9368b918b0b211e2fabd72ac5d19c13adcbb2d3645b78680a8849f235ee58620fbe8df440ef8354f2d50d39601879bb7727465335
f771e674faccf150a5210b3abe829d443619c3e6 gui(installer): restrict clicking previous on final step (jp1ac4)
45f91216d5d0991d7aebde8d4c8bc99edaf5521a gui(installer): remove unused fields from final step (jp1ac4)
03c2bd76b8c6c1b721014afb37da7732ddfeb0cd gui(installer): install and start automatically on final step (jp1ac4)
Pull request description:
This is to resolve#679.
The following changes have been made:
- Change title of final step to "Finalize installation"
- Install and load wallet automatically when reaching final step
- Remove fields from `Final` step that are no longer used
This is how the page looks when installing:
The following is only shown for ~1 sec once wallet has been installed and before loading wallet:
ACKs for top commit:
edouardparis:
ACK f771e674faccf150a5210b3abe829d443619c3e6
Tree-SHA512: b5360c77a13e4028331e4072246f1c897aa6fe61b0c8697b33d5c91ed460e55fe76b8808f4779db2b2f0322e27433e5dbb72fd0210cbf77f28a270bd82ea2558
Installer will install bitcoind in a directory
that will have always the same relative path to
the liana datadir.
GUI needs then only a flag "start_internal_bitcoind" set to true
to check the conventional path of the downloaded bitcoind exe
and start the internal bitcoind
To know and manage the fact that gui or installer
started a bitcoind sub process, the process child
is wrapped and passed by the different state of the app.
During installation, the user may choose for Liana to configure and start bitcoind for them.
This internal bitcoind uses as its data directory the `bitcoind_datadir` folder within the
Liana data directory.
If the internal bitcoind option has been selected for a network, it will be automatically
started when the user returns to Liana and stopped when Liana is closed.
Clicking the "Previous" button during installation will default
to the current behaviour, unless a different message is passed to
the function by any given step.
bba5cd63e81a491c28eddc14e4087ba179794a3c gui: installer: convey registering on a signing device isn't always required (Antoine Poinsot)
Pull request description:
As discussed in #545, in some cases we nudge the user to register the descriptor on their signing device although they might not have one. Those cases only ever arise when importing a descriptor (either when recovering from backup or participating in the creation of a descriptor on another laptop), since when the descriptor is created beforehand we can simply detect whether a signing device was used and thereby needs to be registered (implemented since https://github.com/wizardsardine/liana/pull/470).
Therefore, detect when the registration step arises as part of an import process and if so adjust the language to convey registration on a signing device may not be necessary.
Result:
Fixes#545.
ACKs for top commit:
edouardparis:
ACK bba5cd63e81a491c28eddc14e4087ba179794a3c
Tree-SHA512: 5b25b0c980f3e57563fc3c301802a7c4da50d7c80802d3e6a7517f98ee1da60e9d5ebe890ce3b8c34ca882220d920e31c59b79877c9e8f48b72b092d3809acda
