4c810a1d702c67be811525d4f5ad8f6f0ebc1278 CHANGELOG: mention 2 additional fixes to the GUI for 0.2 (Antoine Poinsot)
Pull request description:
ACKs for top commit:
darosior:
self-ACK 4c810a1d702c67be811525d4f5ad8f6f0ebc1278
Tree-SHA512: 8ae3204f4209f8be4033f084e798e888c412a92f7bf787a6f0f5aea51cb5dc6cfeae810a78ab2a60e9769ca5f6f7b120c3a50118b507892a979df6ebf60a3d39
fcc1c21dbb3a735407d0352c555f448ae80fac64 descriptors: use the origin as xpub UID in partial spend info, not the fingerprint (Antoine Poinsot)
4af1a12a2a239a25c3ab50e4943fa7897be40091 descriptors: fix the spending policy inference (Antoine Poinsot)
Pull request description:
The analysis was assuming missing that a `thresh(2, older(x), thresh(k, key1, key2, ..)` policy could be normalized to `thresh(k + 1, older(x), key1, key2, ..)` when `k == the number of keys` (i.e. in case of a N-of-N multisig). This also merges the analysis logic with the parsing check to make sure we don't introduce any inconsistency.
ACKs for top commit:
edouardparis:
utACK fcc1c21dbb3a735407d0352c555f448ae80fac64
Tree-SHA512: d12db2ccf43d20fc85ea6f9fdfe2869948d2c63a2af22287c9133cf6f732fe92c7c0c63ba70ea3dfb0c910a93753ebd42cb168b4cf6bd6ccbed4e1cc7028b614
42940f638598b02acf1cc4f175703725a2ef3cf2 fix: drop connections to hws in share xpub panel (edouard)
Pull request description:
Use needs to be able to start new connections
in the register descriptor step.
ACKs for top commit:
edouardparis:
Self-ACK 42940f638598b02acf1cc4f175703725a2ef3cf2
Tree-SHA512: 01b146209cb74e5db7819e7249b51881e0f773d32ae2b1400914e0751f702325447b304eeca0f4eadf50113c4ea0535d24c73ef8b311c9de453877659933650f
f545747080fdfc4a02216256a6b6da2e3d22078d gui: reword some warnings on invalid input (Antoine Poinsot)
c6127c41c99d9775ecc177928a2ec9fdc94e13a0 gui: wording nit on missing feerate when creating a spend. (Antoine Poinsot)
a7f2ca1cbee7030e9c51506a2c6e1136f6b3a463 gui: Remove redundant "or" when filling up xpub in installer. (Antoine Poinsot)
Pull request description:
Some things i noticed while testing. Not perfect nor comprehensive, but still an improvement IMO.
ACKs for top commit:
edouardparis:
ACK f545747080fdfc4a02216256a6b6da2e3d22078d
Tree-SHA512: c1b098058cbff6617fb197d235ef6755702499b435414659317be2d0bfffe91e018d9069d1e5741c80b446fbee395cb4f6e7cbc4d457583a3bc04f66d9f3cbc6
af058d59e3604cebb7384f4c0f65a2fd60cc5af4 bitcoind: detect deposits from (mature) coinbase transactions (Antoine Poinsot)
Pull request description:
What if miners use Liana! 😁
ACKs for top commit:
edouardparis:
⛏️ utACK af058d59e3604cebb7384f4c0f65a2fd60cc5af4
Tree-SHA512: 579e24b78d250c095e1073e6e1df46bbea77afdcde6ee8dcef7adc29ef276b6609ccc829809dd97c2da8679ffb6d7b60041572a017438cc7695acdc6afad5b71
We were using the fingerprint as a stable unique identifier for xpubs in
a descriptor. It's not. For instance, what if a single signer is used
both in the primary and recovery path? The same fingerprint would appear
in both paths and we would mix up the signatures for both paths (ie if a
signature for each was provided, we would count each path as having 2
signatures).
c7dd94b7488ddfbe96b91a9eb1f0430c7c0b3f3a fix gui: use address.is_valid_for_network (edouard)
Pull request description:
Use this nice helper from rust-bitcoin, instead
of wrong checks.
ACKs for top commit:
edouardparis:
Self-ACK c7dd94b7488ddfbe96b91a9eb1f0430c7c0b3f3a
Tree-SHA512: f71775c84bde155e6c30ef3b25a064feaf10b95ca9a50395afd0b1808eeb1a9739f66a657cf36754e7d0648324e08469d7ecf3d9bad427b151e6956ee68db7df
697fb16db976d0bc643381b10342f2df650a4386 Add more information and checkbox to register descriptor step (edouard)
Pull request description:
close#297
ACKs for top commit:
darosior:
utACK 697fb16db976d0bc643381b10342f2df650a4386 -- text looks good to me.
Tree-SHA512: 2bfdad9e512612e8cdc5247d0d2a4b35686f97b31fea508f6674baa5e7b1beb5a7929377a9cb3b843644597d186bff67f0200c1d08b6bd2d335477dbcaa83456
263f00150d37908d97bb491cd0dbc2180f36b654 fix: spend minimal amount in btc (edouard)
Pull request description:
"> 5000 sats" message was confusing with the actual amount in btc requirement
ACKs for top commit:
edouardparis:
Self-ACK 263f00150d37908d97bb491cd0dbc2180f36b654
Tree-SHA512: 7846344af9e044db5431d583214c06cdbabfbb5a553be975531e76b5218bec3c7fd0467d11fe4fa2845226516cf09e45d0948df17b2a8c723a3cedb212fe34d0
ea4f02172824371ef162db9ee0b974ef4597a541 fix hws list reloading (edouard)
Pull request description:
I wanted the refresh button to add more harware wallet to the list without erasing the previous list
in order to not cut the existing communication channels.
But with the new display of "unsupported wallet" this behaviour can corrupt the list. An "unsupported wallet" can become "supported" because user switch app or unlock.
It is preferable to reset the full list and drop the objects after a refresh.
ACKs for top commit:
edouardparis:
Self-ACK ea4f02172824371ef162db9ee0b974ef4597a541
Tree-SHA512: 530cf6e82f5bfd325e45c0eb19af94a58e930ecc15a692e0d545ceec2105122ed539a9f671449d2bc05e87c0ba562a1f192076a5cd1a2264f322b5a9094c1d9a
I wanted the refresh button to add more harware wallet
to the list without erasing the previous list
in order to not cut the existing communication channels.
But with the new display of "unsupported wallet" this behaviour
can corrupt the list. An "unsupported wallet" can become
"supported" because user switch app or unlock.
It is preferable to reset the full list and drop the objects
after a refresh.
58a3d21eff766627bde45727f00e101408983602 contrib: update the package pins in the repro build Dockerfiles (Antoine Poinsot)
0bd3bd4d2ef8f88bde2f9abbeed8c1d68408801b Update Github links to wizardsardine/liana (Antoine Poinsot)
ca05bd3fbc2862d3f219491c396b7c1e21b83a99 gui: release 0.2 (Antoine Poinsot)
Pull request description:
Based on #310. Needs to be updated once it is merged.
ACKs for top commit:
darosior:
self-ACK 58a3d21eff766627bde45727f00e101408983602 -- did a full release build on this branch.
Tree-SHA512: 3b7c5a9a5df154dbce5f3615143e8e251c3155a493dc62758ce21a59a640befe469445a171774dcd8e6e1166c9ca0613e9c076a7b073b5b847eb025c13ab56af
3a573b695e07d357e844dd9d573d578e05ecebed qa: test we discard RBF'd deposits (Antoine Poinsot)
f1532f8afcceb5ded299f5ddc425c0473de49871 bitcoin: track expired unconfirmed deposits, remove them from DB (Antoine Poinsot)
ed156543c95db2e6e1fd4712ec7dcb0dfc025c41 database: permit to remove coins from DB (Antoine Poinsot)
62c4b9a01c16c60f66db99abab967efa4e0429dd bitcoind: cleanup gettx cache and conflict detection in spent_coins (Antoine Poinsot)
201c9f21b60dbc5ff0afd9aa73c3a011c08e4459 bitcoin: cache calls to 'gettransaction' when checking for coins confirmation (Antoine Poinsot)
13214c887f373fbe953c01aa8d3a31ae9b65ee98 qa: test we discard RBF'd deposits when replacement is confirmed (Antoine Poinsot)
Pull request description:
Previously we would not detect whether the transaction for an unconfirmed deposit was still in our mempool. For instance a deposit that was RBF'd would result in us storing two coins, the replaced and the replacement. Keeping the unconfirmed replaced coin forever.
Fix this by dropping unconfirmed coins from our database if their transaction isn't in our mempool (anymore).
Fixes#72.
ACKs for top commit:
edouardparis:
utACK 3a573b695e07d357e844dd9d573d578e05ecebed
Tree-SHA512: 677bedbf8024eb16e5f97264c2e01d733732673548772fc3a97868b9ca42a0429ad8c0d888b05d3bb2db9b85d309c418b916c9af578f54e499b5d0689376a1b0
This is the same logic as the (cleaner) one we introduced in
confirmed_coins. Merge the two in a single CachedTxGetter, unfortunaly
at the expense of having to clone() the GetTxRes for now because i don't
want to fight with the borrow checker.
