b7f35c03300710c71f5e8a4af471260f0a35ddc0 Add installer dropdown for advanced settings (edouardparis)
59a4b181c1e1be64ed8122edd95a7378ebef39af fix: merge tap_script_sigs from signed psbt (edouardparis)
02a52b98bcdbcf62d42c748b154beaee76d0f26a add ledger version support for tapminiscript (edouardparis)
2debb32181f2365fb4e30d9d7e28a4cb7c86cd65 Add taproot support to installer descriptor editor step (edouardparis)
8bc0cac00a4894c316285223924e91a85f1c6088 gui: async-hwi:0.0.16 (edouardparis)
4a4c78d5f7ed43aae1199481fb060e77d1d88c80 bump liana:master (edouardparis)
Pull request description:
based on #985
ACKs for top commit:
darosior:
tACK b7f35c03300710c71f5e8a4af471260f0a35ddc0 -- i've lightly tested this a couple times. It's good enough to get in and get tested along with the other changes.
Tree-SHA512: 4481be4797cf6fa901de9fec989837381c7817d18dd2c9a45ff1802a15982d1251696e577fb23da2d4ca9f0ed27044dade28f0e7b56703594dae4b3a5065306b
9415dc939080caa5bf41e93c8717dd0b75bb6a0e new_amount_btc (pythcoiner)
Pull request description:
This PR replace #977 and fixes#798
I've followed jp1ac4 advice and create a `Form::new_amount_btc()` method that act like `Form::new_trimmed()` ~w/ few more (filtering) features:~
~- allow only input of "0123456789,." characters~
~- "," is replaced by "."~
~- only one "." separator~
~- maximum 8 digit after separator~
~these features works for keyboard input or paste~
~i've tryied to add a "0" in case the String start with a "." but this make the cursor have a bad location and i do not find a way to control the cursor location w/ iced, so i revert this feature~
ACKs for top commit:
jp1ac4:
ACK 9415dc9390.
edouardparis:
ACK 9415dc939080caa5bf41e93c8717dd0b75bb6a0e
Tree-SHA512: c8387e5fd9c3c030a71d0ba4a7aa3cd7f834215000f04e4e4d6b689c6bc9bf9dcecbf8b0799882f00f92d5bb8a656714f5149479e7f25e608a0ce96326a6e630
when a pending tx is confirmed, it is pushed in the
HistoryTransaction list at the end. It should be first
in the list. We sort now the list in order to make sure
it will be always the case.
Once a psbt was generated with the recovery panel
it is impossible for user to start again a recovery process
He is redirected to the previous generated psbt because
of the panel state being not reset.
This commit reset the panel state on reload.
492baeaabaf181523d0aac3ac1da8ce2ca837ece gui: hint at rescan when importing wallet (jp1ac4)
Pull request description:
This is to resolve#866.
I've added the message to the first step where the user enters the descriptor:
ACKs for top commit:
edouardparis:
ACK 492baeaabaf181523d0aac3ac1da8ce2ca837ece
Tree-SHA512: 7899ca979b2988d18e6d7be35bad4029db0f1c45f332739f779b532059a710be70463bb85167ffc04491dae35d9300e051788da92bd63ca67a301576b449ad8b
d2c4f136649c0a259b29531487737a50a2339be9 Add hint for hw errors (edouardparis)
Pull request description:
Signing fails if another process has an open connection with a Ledger for example. Async-hwi needs to have a more detailed error api in order to handle graciously errors, but for now we provide a hint to what to check for the user
close#381
ACKs for top commit:
jp1ac4:
utACK d2c4f13664.
Tree-SHA512: 651c123e4f65af7080a6617062c98fb58f03b3b564c3bd104332eaa198b27242bda180118c996b46822b27168fabdd1ff422a9dfd2285db479f0332edc8908a4
e05e42136801e3168b99be378ae85e2852a8ccf6 refac ui: expose badge_pill width (edouardparis)
66f392c7543a013d0ba7eed8a3104538dd10f1f5 fixed size for badges (pythcoiner)
Pull request description:
this PR try to fix#509
i refactored some badges , moving (optional) `batch` badge before mandatory ones and give fixed positions/size for mandatory badges
before:
after:
ACKs for top commit:
edouardparis:
ACK e05e42136801e3168b99be378ae85e2852a8ccf6
Tree-SHA512: 9e7efa8aec40540255666350f2aea3f7175cb2fd161152e30335eb2a8b605ba5fa8fbac9cce90e7e3e53aab3ca71c8cc855ae8448ddfed337cf2eca2dc3d2e2a
This will allow bitcoind to start also in case of using rpcauth.
The cookie file is canonicalized in the installer beforehand
instead.
There is now no need for the config parameter to be mutable.
pending events and txs are passed unpaginated and
in full list through PendingTransactions and PendingPayments.
It is useless and armful to append to them to an existing
list of pending events as a new rbf replacement event should
override the previous one and only one of them must be displayed.
When going back to send panel, coins are fetched
again and passed to DefineSpendStep. A redraft
is triggered because some coins may have been
removed from the list and new coins were deposited.
When user clicks on the sidebar menu
of the current panel, he expects the
view to reset to its initial state
without modal of transaction detail
for example.
46cd0f4923c5fe59a5ff08134c850d9a9ceb345a gui: add max checkbox for spend recipients (jp1ac4)
83fa9a9c924bb1326b859f1d2d5aac58c291e960 gui: unset amount left to select if form invalid (jp1ac4)
fba77a30e2aa9984cbda0fdaf40736ff1b0e57c4 gui: check if feerate is already set (jp1ac4)
d9b8285fac1288e895d4b460646f73c664d1a2ff gui: fix cargo fmt (jp1ac4)
Pull request description:
This adds the MAX button from #546.
The max amount is calculated within the `redraft` function based on the change output. The recipient's amount is updated directly within this same function in order to avoid another call to `redraft` after updating the amount.
The MAX button only takes effect once when the user clicks it. If further changes are made (e.g. to feerate or other recipients), the value will not update and the user will need to click MAX again.
Currently, the MAX button is always clickable. It would be possible to determine for each recipient whether the MAX button should be clickable for that recipient (feerate is valid and all other recipients are valid and no duplicates), but it's not a trivial change so I'm not sure if it's worth doing as I think the behaviour is quite intuitive.
ACKs for top commit:
edouardparis:
ACK 46cd0f4923c5fe59a5ff08134c850d9a9ceb345a
Tree-SHA512: 16f22804d630686427da196fd1627287e2e20f2e122602c385157064323113b27b9ec9c56ada162acb55d11b8084667ee3f1a9f992a2f4eef70f25c6f7a5b20b
Previously, if duplicate addresses were entered when creating
a new spend, the user could click Next and only the second
amount would be used for the draft PSBT.
This prevents the user clicking Next if there are duplicate
addresses and stops the redraft function running.
7483988c53ee6201438283eff496302b7e647176 add index into qrcode (pythcoiner)
Pull request description:
fixes#838
ACKs for top commit:
edouardparis:
utACK 7483988c53ee6201438283eff496302b7e647176
Tree-SHA512: f33dd29f2857cab08c09eca03dcb208937b6b13da9e4ef811cbc4e8e4f6bbb73f1eee629736d98bf00bd9b65be5e96987c18ede42d20c9f486c5ec4e47ada275
3a30a36ce5f58e8ae2c92926384d76253e702894 gui: do not display hw error on simple user refusal (edouardparis)
Pull request description:
close#937
ACKs for top commit:
edouardparis:
Self-ACK 3a30a36ce5f58e8ae2c92926384d76253e702894
Tree-SHA512: c2c1aed212b9389bac62da17552daa6d87d0eeea6180ec19e37dd9ef4dd0faa935a621123df6306ef9ca6fadffba35c1c047d2906a9c15db3a14cd8ccf156e29
416dc9d2d83c3b06ce7e7f5e282a5b9251fa303d gui(installer): clear checkbox if descriptor is changed (jp1ac4)
Pull request description:
Currently, once the box has been ticked to confirm the descriptor has been backed up, it remains ticked even if the user goes back and changes the descriptor.
This PR will clear the checkbox if the descriptor is changed so that the user knows it needs to be backed up
ACKs for top commit:
edouardparis:
ACK 416dc9d2d83c3b06ce7e7f5e282a5b9251fa303d
Tree-SHA512: c8d2be242ada364fe97b0846912420ea206f03f82290dbb87ce513746b8f555f8993d906cd38d27cba513414940bd8984282fc26389608939d89fb252f4c1049
