From 04d895d473102b67421c93b851e550f90b7100ea Mon Sep 17 00:00:00 2001 From: Deluan Date: Fri, 19 Jun 2026 09:16:38 -0400 Subject: [PATCH] test(e2e): wire the DataStore into the lyrics service The lyrics service now queries the DataStore for the legacy artist/title lookup (GetLyricsByArtistTitle). The e2e suites still constructed it with a nil DataStore, so the getLyrics endpoint panicked with a nil-pointer dereference. Pass the suite's existing ds to lyrics.NewLyrics in both e2e routers. --- server/e2e/e2e_suite_test.go | 2 +- server/e2e/subsonic_sonic_similarity_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/e2e/e2e_suite_test.go b/server/e2e/e2e_suite_test.go index a6fe33457..0403306a6 100644 --- a/server/e2e/e2e_suite_test.go +++ b/server/e2e/e2e_suite_test.go @@ -501,7 +501,7 @@ func setupTestDB() { core.NewShare(ds), playback.PlaybackServer(nil), metrics.NewNoopInstance(), - lyrics.NewLyrics(nil, nil), + lyrics.NewLyrics(ds, nil), decider, nil, ) diff --git a/server/e2e/subsonic_sonic_similarity_test.go b/server/e2e/subsonic_sonic_similarity_test.go index 52cfffa11..1b8d34eb1 100644 --- a/server/e2e/subsonic_sonic_similarity_test.go +++ b/server/e2e/subsonic_sonic_similarity_test.go @@ -47,7 +47,7 @@ func buildSonicRouter(provider sonic.Provider) *subsonic.Router { core.NewShare(ds), playback.PlaybackServer(nil), metrics.NewNoopInstance(), - lyrics.NewLyrics(nil, nil), + lyrics.NewLyrics(ds, nil), decider, sonicSvc, )