nik/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-10-18 07:30:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(plugins): pin that an empty variant does not drop later ones

Browse Source 
Signed-off-by: ranokay <github@ranokay.com>
This commit is contained in:
ranokay 2026-10-17 12:39:09 +03:00
parent 1022ffb56a
commit 3998ce224d
No known key found for this signature in database
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
plugins/lyrics_adapter_test.go
View File

@ -186,6 +186,26 @@ var _ = Describe("LyricsPlugin", Ordered, func() {
}
})
It("skips an empty variant without dropping later ones", func() {
manager, _ := createTestManagerWithPlugins(map[string]map[string]string{
"test-lyrics": {
"variants": `[{"text":""},` +
`{"text":"[00:02.00]Real line","provider":"Beta","format":"lrc"}]`,
},
}, "test-lyrics"+PackageExtension)
p, ok := manager.LoadLyricsProvider("test-lyrics")
Expect(ok).To(BeTrue())
result, err := p.GetLyrics(GinkgoT().Context(), &model.MediaFile{
ID: "track-1", Title: "Test Song", Artist: "Test Artist",
})
Expect(err).ToNot(HaveOccurred())
Expect(result).To(HaveLen(1))
Expect(result[0].Line[0].Value).To(Equal("Real line"))
Expect(result[0].Source.Provider).To(Equal("Beta"))
})
It("blocks new calls while the per-plugin concurrency cap is saturated", func() {
sem := provider.plugin.lyricsSem
for range cap(sem) {