From 39f488222f9e4172a5df40e9a76bfa67b854e5ae Mon Sep 17 00:00:00 2001 From: Deluan Date: Tue, 1 Sep 2026 21:08:16 -0400 Subject: [PATCH] test(conf): use non-zero durations in the valid_duration fixture Zero is the boundary between the accepted and rejected ranges, so it passes even if the guard is off by one. 1s exercises an ordinary value. --- conf/configuration_test.go | 4 ++-- conf/testdata/valid_duration.toml | 24 ++++++++++++------------ 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/conf/configuration_test.go b/conf/configuration_test.go index 615ba4dae..2c7f8edaa 100644 --- a/conf/configuration_test.go +++ b/conf/configuration_test.go @@ -477,11 +477,11 @@ var _ = Describe("Configuration", func() { Expect(server.DevPluginCompilationTimeout).To(Equal(consts.DefaultPluginCompilationTimeout)) }) - It("should use parsed values (0) for duration fields", func() { + It("should use parsed values for duration fields", func() { conf.InitConfig(filepath.Join("testdata", "valid_duration.toml"), false) conf.Load(true) - configured := 0 * time.Second + configured := 1 * time.Second server := conf.Server Expect(server.SessionTimeout).To(Equal(configured)) diff --git a/conf/testdata/valid_duration.toml b/conf/testdata/valid_duration.toml index 3adc143fd..6ec4af480 100644 --- a/conf/testdata/valid_duration.toml +++ b/conf/testdata/valid_duration.toml @@ -1,12 +1,12 @@ -SessionTimeout = "0s" -SmartPlaylistRefreshDelay = "0s" -UIPlaybackReportInterval = "0s" -AuthWindowLength = "0s" -DefaultShareExpiration = "0s" -Scanner.WatcherWait = "0s" -DevActivityPanelUpdateRate = "0s" -DevArtworkThrottleBacklogTimeout = "0s" -DevArtistInfoTimeToLive = "0s" -DevAlbumInfoTimeToLive = "0s" -DevInsightsInitialDelay = "0s" -DevPluginCompilationTimeout = "0s" +SessionTimeout = "1s" +SmartPlaylistRefreshDelay = "1s" +UIPlaybackReportInterval = "1s" +AuthWindowLength = "1s" +DefaultShareExpiration = "1s" +Scanner.WatcherWait = "1s" +DevActivityPanelUpdateRate = "1s" +DevArtworkThrottleBacklogTimeout = "1s" +DevArtistInfoTimeToLive = "1s" +DevAlbumInfoTimeToLive = "1s" +DevInsightsInitialDelay = "1s" +DevPluginCompilationTimeout = "1s"