nik/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-05-03 06:51:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: integrate PlaylistGenerator orchestration into plugin manager lifecycle

Browse Source 
Start playlist generator orchestrators after loading enabled plugins.
Stop them on manager shutdown and when individual plugins are unloaded.
This commit is contained in:
Deluan 2026-03-05 07:57:55 -05:00
parent 22ae5bac54
commit 4908dae21f
1 changed files with 38 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
plugins/manager.go
View File

@ -66,6 +66,9 @@ type Manager struct {
ds model.DataStore ds model.DataStore
broker events.Broker broker events.Broker
metrics PluginMetricsRecorder metrics PluginMetricsRecorder
// Playlist generator orchestrators (keyed by plugin name)
playlistGenerators map[string]*playlistGeneratorOrchestrator
} }
// GetManager returns a singleton instance of the plugin manager. // GetManager returns a singleton instance of the plugin manager.
@ -77,6 +80,7 @@ func GetManager(ds model.DataStore, broker events.Broker, m PluginMetricsRecorde
broker: broker, broker: broker,
metrics: m, metrics: m,
plugins: make(map[string]*plugin), plugins: make(map[string]*plugin),
playlistGenerators: make(map[string]*playlistGeneratorOrchestrator),
} }
}) })
} }
@ -165,6 +169,9 @@ func (m *Manager) Start(ctx context.Context) error {
return fmt.Errorf("loading enabled plugins: %w", err) return fmt.Errorf("loading enabled plugins: %w", err)
} }
// Start playlist generators for plugins with the PlaylistGenerator capability
m.startPlaylistGenerators(ctx)
// Start file watcher if auto-reload is enabled // Start file watcher if auto-reload is enabled
if conf.Server.Plugins.AutoReload { if conf.Server.Plugins.AutoReload {
if err := m.startWatcher(); err != nil { if err := m.startWatcher(); err != nil {
@ -176,6 +183,21 @@ func (m *Manager) Start(ctx context.Context) error {
return nil return nil
} }
// startPlaylistGenerators starts orchestrators for all plugins with the PlaylistGenerator capability.
func (m *Manager) startPlaylistGenerators(ctx context.Context) {
m.mu.RLock()
defer m.mu.RUnlock()
for name, p := range m.plugins {
if !hasCapability(p.capabilities, CapabilityPlaylistGenerator) {
continue
}
orch := newPlaylistGeneratorOrchestrator(name, p, m.ds)
m.playlistGenerators[name] = orch
go orch.discoverAndSync(ctx)
}
}
// Stop shuts down the plugin manager and releases all resources. // Stop shuts down the plugin manager and releases all resources.
func (m *Manager) Stop() error { func (m *Manager) Stop() error {
// Mark as stopped first to prevent new operations // Mark as stopped first to prevent new operations
@ -186,6 +208,12 @@ func (m *Manager) Stop() error {
m.cancel() m.cancel()
} }
// Stop all playlist generator orchestrators
for name, orch := range m.playlistGenerators {
orch.stop()
delete(m.playlistGenerators, name)
}
// Stop file watcher // Stop file watcher
m.stopWatcher() m.stopWatcher()
@ -559,6 +587,12 @@ func (m *Manager) unloadPlugin(name string) error {
delete(m.plugins, name) delete(m.plugins, name)
m.mu.Unlock() m.mu.Unlock()
// Stop playlist generator orchestrator if any
if orch, ok := m.playlistGenerators[name]; ok {
orch.stop()
delete(m.playlistGenerators, name)
}
// Run cleanup functions // Run cleanup functions
err := plugin.Close() err := plugin.Close()
if err != nil { if err != nil {