nik/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-05-03 06:51:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(smartplaylist): remove unused 'value' field and clarify 'random' usage

Browse Source 
Signed-off-by: Deluan <deluan@navidrome.org>
This commit is contained in:
Deluan 2026-04-28 20:44:54 -04:00
parent 0fd9c6df2e
commit 57fc85f434
3 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
model/criteria/fields.go
View File

@ -88,8 +88,8 @@ var fieldMap = map[string]FieldInfo{
// Backward compatibility: albumtype is an alias for the releasetype tag. // Backward compatibility: albumtype is an alias for the releasetype tag.
"albumtype": {Alias: "releasetype", IsTag: true}, "albumtype": {Alias: "releasetype", IsTag: true},
// Pseudo-field for random sorting
"random": {}, "random": {},
"value": {},
} }
// AllFieldNames returns the names of all registered criteria fields. // AllFieldNames returns the names of all registered criteria fields.

7
model/criteria/fields_test.go
View File

@ -22,13 +22,6 @@ var _ = Describe("fields", func() {
gomega.Expect(field.IsTag).To(gomega.BeTrue()) gomega.Expect(field.IsTag).To(gomega.BeTrue())
}) })
It("finds special fields", func() {
field, ok := LookupField("value")
gomega.Expect(ok).To(gomega.BeTrue())
gomega.Expect(field.Name()).To(gomega.Equal("value"))
})
It("finds registered tag names", func() { It("finds registered tag names", func() {
AddTagNames([]string{"task3_mood"}) AddTagNames([]string{"task3_mood"})

1
persistence/criteria_sql.go
View File

@ -117,7 +117,6 @@ var smartPlaylistFields = map[string]smartPlaylistField{
"rgtrackpeak": {expr: "media_file.rg_track_peak"}, "rgtrackpeak": {expr: "media_file.rg_track_peak"},
"library_id": {expr: "media_file.library_id"}, "library_id": {expr: "media_file.library_id"},
"random": {order: "random()"}, "random": {order: "random()"},
"value": {expr: "value"},
} }
func (c smartPlaylistCriteria) Where() (squirrel.Sqlizer, error) { func (c smartPlaylistCriteria) Where() (squirrel.Sqlizer, error) {