nik/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-10-18 07:30:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(plugins): pass lookup context instead of storing it in lyricsCall

Browse Source 
Satisfies the containedctx linter: the call keeps only its cancel func and
hands the timeout context straight to run().

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016L1sBqsygMkdhf583gTEnE
This commit is contained in:
Claude 2026-10-15 10:02:26 +00:00
parent 7f0e688fa4
commit 60a443a2f9
No known key found for this signature in database
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/lyrics_adapter.go
View File

@ -37,7 +37,6 @@ type lyricsCallGroup struct {
type lyricsCall struct {
group *lyricsCallGroup
key string
ctx context.Context
cancel context.CancelFunc
done chan struct{}
lyrics model.LyricList
@ -62,7 +61,6 @@ func (g *lyricsCallGroup) join(
call := &lyricsCall{
group: g,
key: key,
ctx: ctx,
cancel: cancel,
done: make(chan struct{}),
waiters: 1,
@ -73,12 +71,12 @@ func (g *lyricsCallGroup) join(
g.calls[key] = call
g.mu.Unlock()
go call.run(lookup)
go call.run(ctx, lookup)
return call
}
func (c *lyricsCall) run(lookup func(context.Context) (model.LyricList, error)) {
lyrics, err := lookup(c.ctx)
func (c *lyricsCall) run(ctx context.Context, lookup func(context.Context) (model.LyricList, error)) {
lyrics, err := lookup(ctx)
c.group.mu.Lock()
c.lyrics = lyrics