From 60fff953de37574ea8f7465b9c0c8c0f3828c111 Mon Sep 17 00:00:00 2001 From: Deluan Date: Tue, 1 Sep 2026 18:45:01 -0400 Subject: [PATCH] docs(artwork): say why media files are exempt from settling absent MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The comment justified the exemption with the fallback to disc or album art, which is true of any track but is not the reason. Media files resolve embedded-only, from a local read, and nothing but a view ever enqueues one — so there is no provider to protect and nothing to gain from recording a state that stops the retry. --- core/artwork/housekeeping.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/artwork/housekeeping.go b/core/artwork/housekeeping.go index 2e07fb296..3ca452bdc 100644 --- a/core/artwork/housekeeping.go +++ b/core/artwork/housekeeping.go @@ -31,7 +31,8 @@ func KeepsState(kind model.Kind) bool { return kind != model.KindDiscArtwork } var RefreshableKinds = append(slices.Clone(ReprocessKinds), model.KindMediaFileArtwork) // settlesAbsentOnGiveUp reports whether an exhausted retry budget records an absent state. Media -// files are excluded: a track with no row still falls back to its disc or album art. +// files are excluded because retrying one costs nothing: they resolve embedded-only, from a local +// read, and only a view ever enqueues them. func settlesAbsentOnGiveUp(prefix string) bool { kind, ok := model.ParseKind(prefix) return ok && KeepsState(kind) && kind != model.KindMediaFileArtwork