nik/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-08-31 07:30:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(subsonic): address review issues in getMostPlayedSongs endpoint

Browse Source
This commit is contained in:
Voten641 2026-06-22 20:25:26 +02:00
parent f6d66e11a2
commit 6af63814af
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
persistence/scrobble_repository.go
View File

@ -43,12 +43,18 @@ func (e *dbMostPlayedEntry) PostScan() error {
}
func (r *scrobbleRepository) GetMostPlayed(offset, count int) ([]model.MostPlayedEntry, error) {
if offset < 0 {
offset = 0
}
if count <= 0 {
count = 50
}
userID := loggedUser(r.ctx).ID
sq := Select("m.*", "count(*) as play_count").
From(r.tableName+" s").
LeftJoin("media_file m ON m.id = s.media_file_id").
Where(Eq{"s.user_id": userID}).
GroupBy("s.media_file_id").
GroupBy("m.id").
OrderBy("play_count DESC").
Offset(uint64(offset)).
Limit(uint64(count))
@ -60,16 +66,13 @@ func (r *scrobbleRepository) GetMostPlayed(offset, count int) ([]model.MostPlaye
entries := make([]model.MostPlayedEntry, 0, len(rows))
for i := range rows {
entry := model.MostPlayedEntry{
if rows[i].MediaFile == nil {
continue
}
entries = append(entries, model.MostPlayedEntry{
MediaFile: *rows[i].MediaFile,
PlayCount: rows[i].PlayCount,
}
var err error
entry.Participants, err = r.getParticipants(rows[i].MediaFile)
if err != nil {
return nil, err
}
entries = append(entries, entry)
})
}
return entries, nil
}