From 7b03f8a9e49c1a5ff2709f048f122a8791ec4a65 Mon Sep 17 00:00:00 2001
From: Deluan <deluan@navidrome.org>
Date: Fri, 25 Jun 2021 22:37:58 -0400
Subject: [PATCH] Enable Last.fm scrobbling by default (still requires user's
 authorization)

---
 conf/configuration.go       | 2 +-
 server/serve_index_test.go  | 2 +-
 ui/src/player/PlayerEdit.js | 5 ++++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/conf/configuration.go b/conf/configuration.go
index b9273febe..41441a997 100644
--- a/conf/configuration.go
+++ b/conf/configuration.go
@@ -247,7 +247,7 @@ func init() {
 	viper.SetDefault("devFastAccessCoverArt", false)
 	viper.SetDefault("devactivitypanel", true)
 	viper.SetDefault("devenableshare", false)
-	viper.SetDefault("devenablescrobble", false)
+	viper.SetDefault("devenablescrobble", true)
 }
 
 func InitConfig(cfgFile string) {
diff --git a/server/serve_index_test.go b/server/serve_index_test.go
index f524801b3..c252ee700 100644
--- a/server/serve_index_test.go
+++ b/server/serve_index_test.go
@@ -207,7 +207,7 @@ var _ = Describe("serveIndex", func() {
 		serveIndex(ds, fs)(w, r)
 
 		config := extractAppConfig(w.Body.String())
-		Expect(config).To(HaveKeyWithValue("devEnableScrobble", false))
+		Expect(config).To(HaveKeyWithValue("devEnableScrobble", true))
 	})
 
 	It("sets the lastFMApiKey", func() {
diff --git a/ui/src/player/PlayerEdit.js b/ui/src/player/PlayerEdit.js
index 9b50f7955..6207ad4f4 100644
--- a/ui/src/player/PlayerEdit.js
+++ b/ui/src/player/PlayerEdit.js
@@ -11,6 +11,7 @@ import {
   useTranslate,
 } from 'react-admin'
 import { Title } from '../common'
+import config from '../config'
 
 const PlayerTitle = ({ record }) => {
   const translate = useTranslate()
@@ -47,7 +48,9 @@ const PlayerEdit = (props) => (
         ]}
       />
       <BooleanInput source="reportRealPath" fullWidth />
-      <BooleanInput source="scrobbleEnabled" fullWidth />
+      {config.devEnableScrobble && (
+        <BooleanInput source="scrobbleEnabled" fullWidth />
+      )}
       <TextField source="client" />
       <TextField source="userName" />
     </SimpleForm>