From 86f810123b1bc96055f7f2262516aa77b0b24c4b Mon Sep 17 00:00:00 2001 From: Kendall Garner <17521368+kgarner7@users.noreply.github.com> Date: Mon, 3 Aug 2026 07:32:27 -0700 Subject: [PATCH] round 2 --- plugins/manager_loader.go | 6 ++---- plugins/manifest.go | 2 +- plugins/testdata/test-storage-plugin/manifest.json | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/plugins/manager_loader.go b/plugins/manager_loader.go index 2c09fc575..cf62c9b6b 100644 --- a/plugins/manager_loader.go +++ b/plugins/manager_loader.go @@ -322,7 +322,7 @@ func (m *Manager) loadPluginWithConfig(p *model.Plugin) error { // Configure filesystem access for library permission, applied per instance var fsConfig wazero.FSConfig - if pkg.Manifest.HasLibraryFilesystemPermission() || pkg.Manifest.HasStoragePermissions() { + if pkg.Manifest.HasLibraryFilesystemPermission() || pkg.Manifest.HasStoragePermission() { mounts := []mount{} if pkg.Manifest.HasLibraryFilesystemPermission() { @@ -334,7 +334,7 @@ func (m *Manager) loadPluginWithConfig(p *model.Plugin) error { mounts = buildMounts(ctx, libraries, allowedLibraries, p.AllLibraries, p.AllowWriteAccess) } - if pkg.Manifest.HasStoragePermissions() { + if pkg.Manifest.HasStoragePermission() { pluginStore := getHostStoragePath(p.ID) log.Info(ctx, "Granting read-write filesystem access to plugin storage", "path", pluginStore, "id", p.ID) @@ -344,8 +344,6 @@ func (m *Manager) loadPluginWithConfig(p *model.Plugin) error { }) } - log.Info(ctx, "mounts", "plugin", p.ID, "mounts", mounts) - fsConfig = buildFSConfig(mounts) } diff --git a/plugins/manifest.go b/plugins/manifest.go index 71e37a025..ef70e8d9d 100644 --- a/plugins/manifest.go +++ b/plugins/manifest.go @@ -124,6 +124,6 @@ func (m *Manifest) HasLibraryFilesystemPermission() bool { m.Permissions.Library.Filesystem } -func (m *Manifest) HasStoragePermissions() bool { +func (m *Manifest) HasStoragePermission() bool { return m.Permissions != nil && m.Permissions.Storage != nil } diff --git a/plugins/testdata/test-storage-plugin/manifest.json b/plugins/testdata/test-storage-plugin/manifest.json index 9354dc3ed..7d3a87334 100644 --- a/plugins/testdata/test-storage-plugin/manifest.json +++ b/plugins/testdata/test-storage-plugin/manifest.json @@ -2,7 +2,7 @@ "name": "Test SubsonicAPI Plugin", "author": "Navidrome Test", "version": "1.0.0", - "description": "Test plugin for SubsonicAPI host function", + "description": "Test plugin for storage host function", "permissions": { "storage": { "reason": "persistent storage for testing"