From 8cd3785ac40c05693f0de507d7dce44f471c8f7f Mon Sep 17 00:00:00 2001
From: Deluan <deluan@navidrome.org>
Date: Mon, 22 Dec 2025 03:17:52 -0500
Subject: [PATCH] fix(plugins): improve error handling and logging in plugin
 manager

Signed-off-by: Deluan <deluan@navidrome.org>
---
 plugins/capabilities_test.go   |  2 +-
 plugins/manager.go             | 20 +++++++++++++-------
 plugins/metadata_agent_test.go | 15 ---------------
 3 files changed, 14 insertions(+), 23 deletions(-)

diff --git a/plugins/capabilities_test.go b/plugins/capabilities_test.go
index 9946073e4..35fc3910a 100644
--- a/plugins/capabilities_test.go
+++ b/plugins/capabilities_test.go
@@ -70,7 +70,7 @@ var _ = Describe("Capabilities", func() {
 		})
 
 		It("returns false when capability does not exist", func() {
-			caps := []Capability{}
+			var caps []Capability
 			Expect(hasCapability(caps, CapabilityMetadataAgent)).To(BeFalse())
 		})
 
diff --git a/plugins/manager.go b/plugins/manager.go
index 69460fce8..93fe5c505 100644
--- a/plugins/manager.go
+++ b/plugins/manager.go
@@ -2,6 +2,7 @@ package plugins
 
 import (
 	"context"
+	"crypto/rand"
 	"encoding/json"
 	"fmt"
 	"os"
@@ -68,25 +69,30 @@ func GetManager() *Manager {
 // It should be called once during application startup when plugins are enabled.
 func (m *Manager) Start(ctx context.Context) error {
 	if !conf.Server.Plugins.Enabled {
-		log.Debug("Plugin system is disabled")
+		log.Debug(ctx, "Plugin system is disabled")
 		return nil
 	}
 
 	m.ctx, m.cancel = context.WithCancel(ctx)
 
 	// Initialize wazero compilation cache for better performance
-	m.cache = wazero.NewCompilationCache()
+	var err error
+	m.cache, err = wazero.NewCompilationCacheWithDir(filepath.Join(conf.Server.CacheFolder, "plugins"))
+	if err != nil {
+		log.Error(ctx, "Failed to create wazero compilation cache", err)
+		return fmt.Errorf("creating wazero compilation cache: %w", err)
+	}
 
 	folder := conf.Server.Plugins.Folder
 	if folder == "" {
-		log.Debug("No plugins folder configured")
+		log.Debug(ctx, "No plugins folder configured")
 		return nil
 	}
 
 	// Create plugins folder if it doesn't exist
 	if err := os.MkdirAll(folder, 0755); err != nil {
-		log.Error("Failed to create plugins folder", "folder", folder, err)
-		return err
+		log.Error(ctx, "Failed to create plugins folder", "folder", folder, err)
+		return fmt.Errorf("creating plugins folder: %w", err)
 	}
 
 	log.Info(ctx, "Starting plugin manager", "folder", folder)
@@ -94,7 +100,7 @@ func (m *Manager) Start(ctx context.Context) error {
 	// Discover and load plugins
 	if err := m.discoverPlugins(folder); err != nil {
 		log.Error(ctx, "Error discovering plugins", err)
-		return err
+		return fmt.Errorf("discovering plugins: %w", err)
 	}
 
 	// Start file watcher if auto-reload is enabled
@@ -338,7 +344,7 @@ func (m *Manager) getPluginConfig(name string) map[string]string {
 func (m *Manager) createMetadataAgent(instance *pluginInstance) (*MetadataAgent, error) {
 	// Create a new plugin instance from the compiled plugin
 	plugin, err := instance.compiled.Instance(m.ctx, extism.PluginInstanceConfig{
-		ModuleConfig: wazero.NewModuleConfig().WithSysWalltime(),
+		ModuleConfig: wazero.NewModuleConfig().WithSysWalltime().WithRandSource(rand.Reader),
 	})
 	if err != nil {
 		return nil, err
diff --git a/plugins/metadata_agent_test.go b/plugins/metadata_agent_test.go
index 750b9e25f..0a0a35c99 100644
--- a/plugins/metadata_agent_test.go
+++ b/plugins/metadata_agent_test.go
@@ -6,7 +6,6 @@ import (
 	"runtime"
 
 	extism "github.com/extism/go-sdk"
-	"github.com/navidrome/navidrome/core/agents"
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
 )
@@ -131,18 +130,4 @@ var _ = Describe("MetadataAgent", func() {
 			Expect(images[0].Size).To(Equal(500))
 		})
 	})
-
-	Describe("interface assertions", func() {
-		It("implements all required interfaces", func() {
-			var _ agents.Interface = agent
-			var _ agents.ArtistMBIDRetriever = agent
-			var _ agents.ArtistURLRetriever = agent
-			var _ agents.ArtistBiographyRetriever = agent
-			var _ agents.ArtistSimilarRetriever = agent
-			var _ agents.ArtistImageRetriever = agent
-			var _ agents.ArtistTopSongsRetriever = agent
-			var _ agents.AlbumInfoRetriever = agent
-			var _ agents.AlbumImageRetriever = agent
-		})
-	})
 })