nik/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-08-01 07:21:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs(scanner): correct unsubstantiated comment about UnknownArtist taggers

Browse Source 
The previous comment claimed 'some rippers emit the literal [Unknown
Artist] string' — no such tagger is actually known. The defensive
second clause in the missing-albumartist check was preserving
accidental behavior from the prior parseArtists implementation, not
guarding against a documented real-world case. Rewrite the comment
to be honest about provenance: keep the clause for behavioral parity
and the cheap round-trip defense, but stop asserting facts I can't
back up.
This commit is contained in:
Deluan 2026-05-24 23:35:11 -03:00
parent 4e7c2128f3
commit a4116e01c2
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
model/metadata/map_participants.go
View File

@ -57,10 +57,13 @@ func (md Metadata) mapParticipants() model.Participants {
albumCredits := md.getArtistValues(model.TagAlbumArtistCredit, model.TagAlbumArtistsCredit)
// Treat both "no albumartist tag" and "albumartist tag literally set to
// the UnknownArtist placeholder" as missing — some rippers emit the
// literal '[Unknown Artist]' string, and the original parseArtists path
// (replaced in this branch) substituted UnknownArtist on its own so the
// downstream check matched either case.
// the UnknownArtist placeholder" as missing. Preserves behavioral parity
// with the prior parseArtists path (replaced in this branch), which
// substituted UnknownArtist on its own and then matched either case
// downstream. No concrete tagger known to emit the literal '[Unknown
// Artist]' string, but the cost of keeping the second clause is one
// comparison and it defends against the placeholder round-tripping if
// Navidrome's own UnknownArtist value ever ends up back in a tag.
albumArtistMissing := len(albumNames) == 0 ||
(len(albumNames) == 1 && albumNames[0] == consts.UnknownArtist)