nik/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-08-01 07:21:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(artwork): recompute on original serves when the image cache is disabled

Browse Source 
With ImageCacheSize=0 every serve reads live bytes, so an in-place cover
swap without rescan changed the served image with no signal the worker
could see. Original-size serves now force on disabled caches, and a new
unchanged-hash guard skips the DB write, so the forced path costs only the
background decode those installs already pay per request.
This commit is contained in:
Deluan 2026-07-17 14:13:09 -04:00
parent d0ac427377
commit ae36e4dfc7
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
core/artwork/artwork.go
View File

@ -90,9 +90,11 @@ func (a *artwork) Get(ctx context.Context, artID model.ArtworkID, size int, squa
if a.blurHashes != nil {
// An original-size miss on an operational cache means a new/changed image even when no
// entity row moved. Resized misses don't qualify (their keys vary per size, and their
// readers re-fetch the original through Get, carrying the real signal); nor does cache
// warmup/disabled, where every serve misses — there the LastUpdated signal applies.
force := size == 0 && !square && !r.Cached && a.cache.Available(ctx)
// readers re-fetch the original through Get, carrying the real signal). With the cache
// permanently disabled every serve reads live bytes, so original serves always force
// (the worker's unchanged-hash guard keeps that write-free); warmup forces nothing.
force := size == 0 && !square &&
((!r.Cached && a.cache.Available(ctx)) || a.cache.Disabled(ctx))
a.blurHashes.Enqueue(artID, artReader.LastUpdated(), force, false)
}
return r, artReader.LastUpdated(), nil

5
core/artwork/blurhash_updater.go
View File

@ -198,6 +198,11 @@ func (u *blurHashUpdater) process(ctx context.Context, artID model.ArtworkID, re
}
return
}
// Unchanged hash with an unmoved signal needs no write — keeps forced recomputes (e.g. every
// original serve on cache-disabled installs) from hammering the DB.
if hash == stored && storedAt != nil && !sig.After(*storedAt) {
return
}
if err := u.persist(ctx, artID, hash, sig); err != nil {
log.Warn(ctx, "BlurHash: error persisting", "artID", artID, err)
return