From b4000fb99a0209bc42476b794f1424f70a3b655d Mon Sep 17 00:00:00 2001
From: Deluan <deluan@navidrome.org>
Date: Mon, 9 Feb 2026 08:30:02 -0500
Subject: [PATCH] fix: implement noopDecider for transcoding decision handling
 in tests

Signed-off-by: Deluan <deluan@navidrome.org>
---
 server/e2e/e2e_suite_test.go | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git a/server/e2e/e2e_suite_test.go b/server/e2e/e2e_suite_test.go
index 484a91cc7..602906e2e 100644
--- a/server/e2e/e2e_suite_test.go
+++ b/server/e2e/e2e_suite_test.go
@@ -25,6 +25,7 @@ import (
 	"github.com/navidrome/navidrome/core/playlists"
 	"github.com/navidrome/navidrome/core/scrobbler"
 	"github.com/navidrome/navidrome/core/storage/storagetest"
+	"github.com/navidrome/navidrome/core/transcode"
 	"github.com/navidrome/navidrome/db"
 	"github.com/navidrome/navidrome/log"
 	"github.com/navidrome/navidrome/model"
@@ -227,14 +228,29 @@ func (n noopArtwork) GetOrPlaceholder(_ context.Context, _ string, _ int, _ bool
 // noopStreamer implements core.MediaStreamer
 type noopStreamer struct{}
 
-func (n noopStreamer) NewStream(context.Context, string, string, int, int) (*core.Stream, error) {
+func (n noopStreamer) NewStream(context.Context, core.StreamRequest) (*core.Stream, error) {
 	return nil, model.ErrNotFound
 }
 
-func (n noopStreamer) DoStream(context.Context, *model.MediaFile, string, int, int) (*core.Stream, error) {
+func (n noopStreamer) DoStream(context.Context, *model.MediaFile, core.StreamRequest) (*core.Stream, error) {
 	return nil, model.ErrNotFound
 }
 
+// noopDecider implements transcode.Decider
+type noopDecider struct{}
+
+func (n noopDecider) MakeDecision(context.Context, *model.MediaFile, *transcode.ClientInfo) (*transcode.Decision, error) {
+	return nil, nil
+}
+
+func (n noopDecider) CreateTranscodeParams(*transcode.Decision) (string, error) {
+	return "", nil
+}
+
+func (n noopDecider) ParseTranscodeParams(string) (*transcode.Params, error) {
+	return nil, nil
+}
+
 // noopArchiver implements core.Archiver
 type noopArchiver struct{}
 
@@ -303,6 +319,7 @@ var (
 	_ core.Archiver         = noopArchiver{}
 	_ external.Provider     = noopProvider{}
 	_ scrobbler.PlayTracker = noopPlayTracker{}
+	_ transcode.Decider     = noopDecider{}
 )
 
 var _ = BeforeSuite(func() {
@@ -398,6 +415,7 @@ func setupTestDB() {
 		playback.PlaybackServer(nil),
 		metrics.NewNoopInstance(),
 		lyrics.NewLyrics(nil),
+		noopDecider{},
 	)
 }