From c413d6510e9f09df9fee31c230ed48ab08e4dd5c Mon Sep 17 00:00:00 2001
From: Deluan <deluan@navidrome.org>
Date: Sun, 24 May 2026 22:24:06 -0300
Subject: [PATCH] fix(metadata): drop unused performer/plural-credit tag
 mappings
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Per Copilot & Codex review on PR #5527:

- performercredit was registered as a plain string mapping, but PERFORMER
  is type:pair ('PERFORMER:instrument'). The credit form needs the same
  pair structure to be meaningful, and processPerformers doesn't read it
  either way. Better to remove the misleading mapping than ship dead
  config that suggests support we don't have.

- TagComposersCredit and TagLyricistsCredit (plural variants) were never
  consumed by any code path — only the singular TagComposerCredit and
  TagLyricistCredit are wired into roleMappings.

Both can be added back when the underlying feature is actually
implemented.
---
 model/tag.go            | 6 +++---
 resources/mappings.yaml | 6 ------
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/model/tag.go b/model/tag.go
index e1344cb53..743294658 100644
--- a/model/tag.go
+++ b/model/tag.go
@@ -216,11 +216,9 @@ const (
 	TagComposer           TagName = "composer"
 	TagComposerSort       TagName = "composersort"
 	TagComposerCredit     TagName = "composercredit"
-	TagComposersCredit    TagName = "composerscredit"
 	TagLyricist           TagName = "lyricist"
 	TagLyricistSort       TagName = "lyricistsort"
 	TagLyricistCredit     TagName = "lyricistcredit"
-	TagLyricistsCredit    TagName = "lyricistscredit"
 	TagDirector           TagName = "director"
 	TagDirectorCredit     TagName = "directorcredit"
 	TagProducer           TagName = "producer"
@@ -238,7 +236,9 @@ const (
 	TagArranger           TagName = "arranger"
 	TagArrangerCredit     TagName = "arrangercredit"
 	TagPerformer          TagName = "performer"
-	TagPerformerCredit    TagName = "performercredit"
+	// Performer credits are not currently surfaced: performer tags are
+	// `type: pair` ('PERFORMER:instrument') and the matching credit
+	// representation hasn't been designed yet. Tracked separately.
 
 	// ReplayGain
 
diff --git a/resources/mappings.yaml b/resources/mappings.yaml
index 3f15dcd3d..47b799b15 100644
--- a/resources/mappings.yaml
+++ b/resources/mappings.yaml
@@ -58,16 +58,12 @@ main:
     aliases: [ tsoc, txxx:composersort, composersort, soco, wm/composersortorder ]
   composercredit:
     aliases: [ composer_credit, composercredit ]
-  composerscredit:
-    aliases: [ composers_credit, composerscredit ]
   lyricist:
     aliases: [ text, lyricist, ----:com.apple.itunes:lyricist, wm/writer ]
   lyricistsort:
     aliases: [ lyricistsort ]
   lyricistcredit:
     aliases: [ lyricist_credit, lyricistcredit ]
-  lyricistscredit:
-    aliases: [ lyricists_credit, lyricistscredit ]
   conductor:
     aliases: [ tpe3, conductor, ----:com.apple.itunes:conductor, wm/conductor ]
   conductorcredit:
@@ -225,8 +221,6 @@ main:
   performer:
     aliases: [performer]
     type: pair
-  performercredit:
-    aliases: [ performer_credit, performercredit ]
   musicbrainz_performerid:
     aliases: [ txxx:musicbrainz performer id, musicbrainz_performerid, musicbrainz_performer_id, ----:com.apple.itunes:musicbrainz performer id, musicbrainz/performer id ]
     type: pair