From e329667ab073c9e393b6a0cd25e0eb465687b714 Mon Sep 17 00:00:00 2001 From: Deluan Date: Sun, 3 May 2026 13:50:15 -0400 Subject: [PATCH] fix: address review feedback on authProvider Remove unused vi import from test file. Use Number() || 0 instead of parseInt with string fallback to handle corrupted sessionStorage values that would produce NaN. --- ui/src/authProvider.js | 6 ++---- ui/src/authProvider.test.js | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/ui/src/authProvider.js b/ui/src/authProvider.js index f7ea165f8..e850e62bf 100644 --- a/ui/src/authProvider.js +++ b/ui/src/authProvider.js @@ -87,10 +87,8 @@ const authProvider = { } if (config.extAuthLogoutURL && isNetworkError(error)) { const now = Date.now() - const lastReload = parseInt( - sessionStorage.getItem('ext-auth-reload-ts') || '0', - 10, - ) + const lastReload = + Number(sessionStorage.getItem('ext-auth-reload-ts')) || 0 if (now - lastReload > 30000) { sessionStorage.setItem('ext-auth-reload-ts', String(now)) removeItems() diff --git a/ui/src/authProvider.test.js b/ui/src/authProvider.test.js index fd65bf34a..b37a22e53 100644 --- a/ui/src/authProvider.test.js +++ b/ui/src/authProvider.test.js @@ -1,4 +1,4 @@ -import { describe, it, beforeEach, afterEach, vi, expect } from 'vitest' +import { describe, it, beforeEach, afterEach, expect } from 'vitest' import config from './config' import authProvider from './authProvider'