nik/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-04-03 06:41:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(client): replace sort with slices.SortFunc for deterministic ordering of recordings with same score

Browse Source 
Signed-off-by: Deluan <deluan@navidrome.org>
This commit is contained in:
Deluan 2026-02-07 12:20:56 -05:00
parent a656ca8a49
commit f4ca5ec1ca
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
adapters/listenbrainz/client.go
View File

@ -2,6 +2,7 @@ package listenbrainz
import (
"bytes"
"cmp"
"context"
"encoding/json"
"errors"
@ -10,7 +11,6 @@ import (
"net/url"
"path"
"slices"
"sort"
"github.com/navidrome/navidrome/log"
)
@ -362,8 +362,11 @@ func (c *client) getSimilarRecordings(ctx context.Context, mbid string, limit in
// For whatever reason, labs API isn't guaranteed to give results in the proper order
// and may also provide duplicates. See listenbrainz.labs.similar-recordings-real-out-of-order.json
// generated from https://labs.api.listenbrainz.org/similar-recordings/json?recording_mbids=8f3471b5-7e6a-48da-86a9-c1c07a0f47ae&algorithm=session_based_days_180_session_300_contribution_5_threshold_15_limit_50_skip_30
sort.Slice(recordings, func(i, j int) bool {
return recordings[i].Score > recordings[j].Score
slices.SortFunc(recordings, func(a, b recording) int {
return cmp.Or(
cmp.Compare(b.Score, a.Score), // Sort by score descending
cmp.Compare(a.MBID, b.MBID), // Then by MBID ascending to ensure deterministic order for duplicates
)
})
recordings = slices.CompactFunc(recordings, func(a, b recording) bool {