nik/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-04-03 06:41:01 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,983 Commits 44 Branches 113 Tags 112 MiB
Commit Graph

387 Commits

Author SHA1 Message Date
Deluan
1c869102e6
fix(server): don't try to save JWT if it fails to encrypt 
Signed-off-by: Deluan <deluan@navidrome.org>
 2026-01-02 20:41:57 +00:00
Deluan
05521781a8
fix(server): encrypt jwt secret at rest 
Signed-off-by: Deluan <deluan@navidrome.org>
 2026-01-02 20:41:57 +00:00
Deluan
03fa2920a2
fix(server): more race conditions when updating artist/album from external sources 
Signed-off-by: Deluan <deluan@navidrome.org>
 2026-01-02 20:41:57 +00:00
Deluan
cdcfc99db8
fix(server): add disc number to fake path. 
Also revert "feat(server): enable "Report Real Path" by default"

Signed-off-by: Deluan <deluan@navidrome.org>
 2026-01-02 20:41:57 +00:00
Deluan
b7bb44cc7e
fix(server): race condition when updating artist/album from external sources 
Signed-off-by: Deluan <deluan@navidrome.org>
 2026-01-02 20:41:56 +00:00
Deluan
16f2f849e5
feat(server): get artist images from Last.fm 
Signed-off-by: Deluan <deluan@navidrome.org>
 2026-01-02 20:41:56 +00:00
Deluan
df0ba725c1
feat(server): enable "Report Real Path" by default 
Signed-off-by: Deluan <deluan@navidrome.org>
 2026-01-02 20:41:56 +00:00
Deluan
f7a0484874
fix: pre-cache square images, or else they are not useful for the Album Grid 
Signed-off-by: Deluan <deluan@navidrome.org>
 2026-01-02 20:41:56 +00:00
Deluan
0744038ead
refactor: when resizing, don't buffer the original image "just in case" 
Signed-off-by: Deluan <deluan@navidrome.org>
 2026-01-02 20:41:56 +00:00
Deluan
fd85b458ac
refactor: remove unnecessary intermediate buffer for ffmpeg image extraction 
Signed-off-by: Deluan <deluan@navidrome.org>
 2026-01-02 20:41:56 +00:00
Deluan
17755b7676
refactor: better implementation of newRefreshQueue. 
- use pointer references in channel
 - actually exits when context is canceled

Signed-off-by: Deluan <deluan@navidrome.org>
 2026-01-02 20:41:55 +00:00
Deluan Quintão
54c3b8d14b
fix: forcing transcoding when client does not specify transcoding options (#3455) 
* fix: wip

Signed-off-by: Deluan <deluan@navidrome.org>

* fix: revert #3227

It is not respecting the server configured transcoding for the player

Signed-off-by: Deluan <deluan@navidrome.org>

---------

Signed-off-by: Deluan <deluan@navidrome.org>
 2026-01-02 20:41:22 +00:00
Deluan Quintão
dd94c6689b
fix(server): try to find proper embedded front cover - only for vorbis comments for now (#3348) 
* fix(artwork): get the first image from vorbis comments, not the last. fixes #3254

This uses a fork for now.

* fix(artwork): prioritize getting embedded types that are listed as "front" covers

* fix: cleanup
 2026-01-02 20:41:04 +00:00
Deluan
be017614c5
fix(server): allow extra spaces in transcoding commands 2026-01-02 20:41:03 +00:00
Deluan
a581e3e0c5
refactor(server): remove ffmpeg unused code 2026-01-02 20:41:03 +00:00
Caio Cotts
0d00f29104
fix(playlists): make the m3u parser case-insensitive again #3410 2026-01-02 20:41:03 +00:00
Deluan
b1893ac7c6
fix(server): FFmpegPath can contain spaces 2026-01-02 20:41:03 +00:00
Kendall Garner
b7917f14ff
fix(server): preserve m3u file order on import (#3314) 
* fix(playlist): preserve m3u file order on import - 3307

Signed-off-by: Kendall Garner <17521368+kgarner7@users.noreply.github.com>

* test(server): cover playlist order

* refactor(server): micro-optimizations

* refactor(server): micro-optimizations

* fix(server): playlists imported from reader (POST /playlist) are not synced

* refactor(server): only allocate the capacity required to hold a playlist chunk

---------

Signed-off-by: Kendall Garner <17521368+kgarner7@users.noreply.github.com>
Co-authored-by: Deluan <deluan@navidrome.org>
 2026-01-02 20:40:19 +00:00
Deluan Quintão
f3f66da3da
refactor(server): replace RangeByChunks with Go 1.23 iterators (#3292) 
* refactor(server): replace RangeByChunks with Go 1.23 iterators

* chore: fix comments re: SQLITE_MAX_VARIABLE_NUMBER

* test: improve playqueue test

* refactor(server): don't create a new iterator when it is not required
 2026-01-02 20:39:44 +00:00
Deluan
be25753d37
fix(scanner): improve M3U playlist import times (#2706) 2026-01-02 20:39:42 +00:00
Deluan
dfe07abb72
Fix log message 2026-01-02 20:39:41 +00:00
Vlad Shulcz
20fbd7c740
refactor(core): Refactor selectTranscodingOptions function (#3227) 
* refactor(core): Refactor selectTranscodingOptions function - #3226

Signed-off-by: shulcz <vshulcz@gmail.com>

* chore: Fix selectTranscodingOptions function - #3226

Signed-off-by: shulcz <vshulcz@gmail.com>

* Small refactoring to make code more concise

* Fix log message

---------

Signed-off-by: shulcz <vshulcz@gmail.com>
Co-authored-by: Deluan <deluan@navidrome.org>
 2026-01-02 20:39:14 +00:00
Deluan
a7aa4c1b52
Change DefaultPlaylistPublicVisibility to false 2026-01-02 20:39:13 +00:00
John White
53559f5ba0
feat: imported playlists are public by default (#3143) 
* feat: imported playlists are public by default

* chore: make linter happy

---------

Co-authored-by: John White <john@activecode.dev>
 2026-01-02 20:39:13 +00:00
Rob Emery
48154ef58b
Fixing Build/lint error: "non-constant format string in call to fmt.Errorf (govet)" (#3198) 
* Fixing " non-constant format string in call to fmt.Errorf (govet)"

* Its a string, not an int; read better.
 2026-01-02 20:38:44 +00:00
Deluan Quintão
819d0afd03
Upgrade Go to 1.23 (#3190) 
* Upgrade to Golang 1.23rc1

* Fix imports

* Go 1.23 final version

* Fix lint compatibility with ci-goreleaser
 2026-01-02 20:38:44 +00:00
Deluan
d68dc6d3d7
Reduce noise in logs when pre-caching artwork 2026-01-02 20:37:43 +00:00
Kendall Garner
a50af42872
Use userId in player, other fixes (#3182) 
* [bugfix] player: use userId, other fixes

This PR primarily resolves #1928 by switching the foreign key of `player` from `user.user_name` to `user.id`.
There are also a few other fixes/changes:

- For some bizarre reason, `ip_address` is never returned from `read`/`get`. Change the field to `ip`, which works. Somehow
- Update `players_test.go` mock to also check for user agent, replicating the actual code
- Update `player_repository.go` `isPermitted` to check user id. I don't know how this worked before...
- tests!
- a few places referred to `typ`, when it is really `userAgent`. Change the field names

* baseRequest -> selectPlayer

* remove comment

* update migration, make all of persistence foreign key enabled

* maybe don't forget to save the file first
 2026-01-02 20:37:43 +00:00
Deluan
89138e75f4
Evict expired items from SimpleCache 2026-01-02 20:37:15 +00:00
Deluan
843d48f448
Upgrade to ttlcache/v3 2026-01-02 20:37:15 +00:00
Deluan
10ab9cfb55
Wrap ttlcache in our own SimpleCache implementation 2026-01-02 20:37:15 +00:00
Deluan
883c6bb591
Change resized image cache key 2026-01-02 20:37:00 +00:00
Deluan
fe600067da
Fix race condition in external metadata retrieval 2026-01-02 20:37:00 +00:00
Deluan
4783fe395e
Small refactoring 2026-01-02 20:36:59 +00:00
Deluan
38a219648d
Refactor string utilities into its own package str 2026-01-02 20:36:59 +00:00
Deluan
30671bf0dc
Fix tests expectations 2026-01-02 20:36:59 +00:00
Caio Cotts
ce5a6aa4fd
Fix image stuttering (#3035) 
* Fix image stuttering.

* Fix docker publishing for PRs

* Write tests for new square parameter.

* Simplify code for createImage.

---------

Co-authored-by: Deluan Quintão <deluan@navidrome.org>
 2026-01-02 20:36:59 +00:00
Deluan
47068d2dea
Optimize SQLite3 access. Mainly separate read access from write access. 
Based on tips from https://archive.is/Xfjh6#selection-257.0-278.0
 2026-01-02 20:36:58 +00:00
Deluan
880af2efe1
Refactor random.WeightedChooser, unsing generics 2026-01-02 20:36:57 +00:00
Deluan
e34c657e42
Simplify image format detection code 2026-01-02 20:36:57 +00:00
Deluan
e08e353763
Improve resizeImage code readability 2026-01-02 20:36:57 +00:00
Fynn Petersen-Frey
9bae65167c
fix bug in jukebox: property unavailable (#3024) 
* fix bug in jukebox: property unavailable

* fix lint error
 2026-01-02 20:36:57 +00:00
Deluan
af627aa18e
Refactor random functions 2026-01-02 20:36:56 +00:00
Deluan
56964b676d
Refactor cache.HTTPClient 2026-01-02 20:36:56 +00:00
Deluan
d68cdac3d2
Do not panic if when updatePlaylist is called with a non-existent ID. 
Fix #2876
 2026-01-02 20:36:55 +00:00
Deluan Quintão
9e9f72ae8a
Make sorting lists by name/title case-insensitive (#2993) 
* Make sort by order_* fields case-insensitive.

* Sort internet radios by name case-insensitive
 2026-01-02 20:36:55 +00:00
Deluan Quintão
9ff3145845
Terminate all MPV instances when stopping Navidrome (#3008) 
* Terminate all mpv instances when stopping Navidrome

* Exit trackSwitcher goroutine when terminating

* Remove potential race condition when starting the Playback device

* Fix lint error

* Removed unused and unneeded vars/functions

* Use device short name in log

* Small refactor

* Small nitpick

* Make start functions more uniform
 2026-01-02 20:36:55 +00:00
Deluan
6640509044
Make dependency injection more consistent 2026-01-02 20:36:55 +00:00
Matthias Schmidt
7cd38f9742
Guard against missing active track (#2996) 
Co-authored-by: Deluan Quintão <deluan@navidrome.org>
 2026-01-02 20:36:35 +00:00
Matthias Schmidt
2c6216817d
Persist adjusted volume (#2997) 
Co-authored-by: Deluan Quintão <deluan@navidrome.org>
 2026-01-02 20:36:35 +00:00