538 Commits

Author SHA1 Message Date
Deluan
57b3e22067
Simplify default middlewares setup 2026-01-02 20:32:58 +00:00
Deluan
5824737dc9
Simplify RealIP middleware setup 2026-01-02 20:32:58 +00:00
Johannes Engl
74deddef91
Make server unix socket file permission configurable via flag UnixSocketPerm (#2763)
* feat(any): Add flag unixsocketperm with default 0017 - #2625

Signed-off-by: johannesengl <hello@johannesengl.com>

* feat(server): Update unix socket file perm based on config - #2625

Signed-off-by: johannesengl <hello@johannesengl.com>

* Fix default value of socket.

* Refactor unix socket file creation.

* Remove misplaced comment

---------

Signed-off-by: johannesengl <hello@johannesengl.com>
Co-authored-by: Caio Cotts <caio@cotts.com.br>
Co-authored-by: Deluan <deluan@navidrome.org>
2026-01-02 20:32:38 +00:00
Deluan
faed89622d
Fix ReplayGain values not being retrieved from DB 2026-01-02 20:32:37 +00:00
Kendall Garner
044c8c09ac
Add OS Lyrics extension (#2656)
* draft commit

* time to fight pipeline

* round 2 changes

* remove unnecessary line

* fight taglib. again

* make taglib work again???

* add id3 tags

* taglib 1.12 vs 1.13

* use int instead for windows

* store as json now

* add migration, more tests

* support repeated line, multiline

* fix ms and support .m, .mm, .mmm

* address some concerns, make cpp a bit safer

* separate responses from model

* remove [:]

* Add trace log

* Try to unblock pipeline

* Fix merge errors

* Fix SIGSEGV error (proper handling of empty frames)

* Add fallback artist/title to structured lyrics

* Rename conflicting named vars

* Fix tests

* Do we still need ffmpeg in the pipeline?

* Revert "Do we still need ffmpeg in the pipeline?"

Yes we do.

This reverts commit 87df7f6df79bccee83f48c4b7a8118a7636a5e66.

* Does this passes now, with a newer ffmpeg version?

* Revert "Does this passes now, with a newer ffmpeg version?"

No, it does not :(

This reverts commit 372eb4b0ae05d9ffe98078e9bc4e56a9b2921f32.

* My OCD made me do it :P

---------

Co-authored-by: Deluan Quintão <deluan@navidrome.org>
2026-01-02 20:32:37 +00:00
Deluan
0d18620030
Add log.IsGreaterOrEqualTo, that take into consideration path-scoped log levels 2026-01-02 20:32:37 +00:00
Deluan Quintão
7eefae4a7c
Implement originalReleaseDate in OpenSubsonic responses. (#2733)
See https://github.com/opensubsonic/open-subsonic-api/pull/80
2026-01-02 20:32:37 +00:00
Deluan
81bf9d23e4
Replace all utils.Param* with req.Params 2026-01-02 20:32:36 +00:00
Deluan
b932d0cbf1
Add req.Params to replace utils.Param* 2026-01-02 20:32:36 +00:00
Deluan
add688e594
Some cleanup in the jukebox code, specially log messages 2026-01-02 20:32:35 +00:00
Deluan
917b974100
Change required fields in Subsonic Jukebox endpoint
See discussion here: https://gitlab.com/ultrasonic/ultrasonic/-/issues/1266#note_1621953651
2026-01-02 20:32:35 +00:00
Deluan
4ef7fd2e9c
Fix possible authentication bypass 2026-01-02 20:32:35 +00:00
Kendall Garner
ed43e620cf
Allow reverse proxy auth for unix socket (#2701) 2026-01-02 20:32:24 +00:00
Deluan
5dcb7479cb
Removed duplicated code 2026-01-02 20:31:57 +00:00
Deluan
07201e7a9b
Return AlbumID3 in search3 results 2026-01-02 20:31:57 +00:00
Deluan
70148afc63
Convert internal disc number representation to int 2026-01-02 20:31:57 +00:00
Deluan
9a4b35bcaf
Add discTitles to OpenSubsonic responses 2026-01-02 20:31:57 +00:00
Deluan Quintão
274ad1f7d5
Replace beego/orm with dbx (#2693)
* Start migration to dbx package

* Fix annotations and bookmarks bindings

* Fix tests

* Fix more tests

* Remove remaining references to beego/orm

* Add PostScanner/PostMapper interfaces

* Fix importing SmartPlaylists

* Renaming

* More renaming

* Fix artist DB mapping

* Fix playlist updates

* Remove bookmarks at the end of the test

* Remove remaining `orm` struct tags

* Fix user timestamps DB access

* Fix smart playlist evaluated_at DB access

* Fix search3
2026-01-02 20:31:57 +00:00
Deluan Quintão
24631bc105
Return http form post extension (OpenSubsonic) (#2676) 2026-01-02 20:31:56 +00:00
Deluan
c7deb6fc66
Add ReplayGain to OpenSubsonic API Child response 2026-01-02 20:31:56 +00:00
Deluan
31a599a39a
Add support for timeOffset in /stream endpoint 2026-01-02 20:31:56 +00:00
Deluan
c166e2044d
Add more OpenSubsonic fields
- isCompilation
- sortName
2026-01-02 20:31:56 +00:00
Deluan
2cd2444ebc
Add more OpenSubsonic fields
- mediaType
- musicBrainzId (Child)
2026-01-02 20:31:56 +00:00
Deluan
fd6259df9f
Fix getOpenSubsonicExtensions endpoint
Match the current doc: https://opensubsonic.netlify.app/docs/endpoints/getopensubsonicextensions/

openSubsonicExtensions must be an array, not a struct
2026-01-02 20:31:30 +00:00
Deluan
2d5881be7a
Make ParamInt generic (any int type) 2026-01-02 20:31:12 +00:00
Caio Cotts
94eefe62df
Return genres in search3 endpoint. 2026-01-02 20:31:12 +00:00
Caio Cotts
ea753cc819
Fix marshaling for genres. 2026-01-02 20:31:12 +00:00
Deluan
5f2d2412c9
Format subsonic response snapshots 2026-01-02 20:31:11 +00:00
Drew Weymouth
78f22159ea
Expose OpenSubsonic fields Genres, MusicBrainzId, Bpm, Comment (#2597)
* add Genres to subsonic responses

* add genres in GetAlbum response

* add musicBrainzId

* add Bpm and Comment OpenSubsonic fields

* remove omitempty on OpenSubsonic fields

* add custom JSON marshalers to ensure genres attribute is non-nil

* regenerate snapshots to capture now-mandatory fields
2026-01-02 20:31:11 +00:00
certuna
7b7d03989d
Fix hardcoded IPv4 literals (#2602)
* Update server_test.go

no hardcoded IPv4 literals

* Update package.json

no hardcoded IPv4 literals
2026-01-02 20:29:59 +00:00
Sam Watson
b7585dc689
POST endpoint for importing m3u playlists - #2078 (#2273)
* wip: API endpoint for creating playlists from m3u files

* wip: get user id from context

* temporarily disable failing test

* custom logic for playlist route to accomodate m3u content type

* incorporate playlist parsing into existing logic in core

* re-enable test

* fix locally failing test

* Address requested changes.

* Improve ImportFile tests.

* Remove ownerID as a parameter of ImportM3U.

* Write tests for ImportM3U.

* Separate ImportM3U test into two.

* Test OwnerID and playlist Name.

---------

Co-authored-by: Sam Watson <SwatsonCodes@users.noreply.github.com>
Co-authored-by: caiocotts <caio@cotts.com.br>
2026-01-02 20:29:58 +00:00
Deluan
4733c5bbd9
Make Jukebox available to Subsonic clients 2026-01-02 20:29:58 +00:00
Matthias Schmidt
e31500e80e
Jukebox mode (#2289)
* Adding cache directory to ignore-list

* Adding jukebox-related config options

* Adding DevEnableJukebox config option pls. dummy server

* Adding types and routers

* Now without panic

* First draft on parsing the action

* Some cleanups

* Adding playback server

* Verify audio device configuration

* Adding debug-build target to have full symbol support

* Adding beep sound library pls some example code. Not working yet

* Play a fixed mp3 on any interface access for testing purposes

* Put action code into separate file, adding stringer, more debug output, prepare structs, validation

* Put action parameter parser code where it belongs

* Have a single Action transporting all information

* User fmt.Errorf for error-generation

* Adding wide playback interface

* Use action map for parsing, stringer instead switch stmt.

* Use but only one switch case and direct dispatch, refactoring

* Add error handling and pushing to client

* send decent errormessage, no internal server error

* Adding playback devices slice and load it from config

* Combine config-verification and structure init

* Return user-specific device

* Separate playback server from device

* Use dataStore to retrieve mediafile by id

* WIP: Playlist and start/stop handling. Doing start/stop the hard way as of now

* WIP: set, start and stop work on one single song. More to come

* Dont need to wait for the end

* Merge jukebox_action.go into jukebox.go

* Remove getParameterAsInt64(). Use existing requiredParamInt() instead

* Dont need to call newFailure() explicitly

* Remove int64, use int instead.

* Add and set action now accept multiple ids

* Kickout copy of childFromMediaFile(). It is not needed here.

* Refactoring devices and playbackServer

* Turn (internal) playback.DeviceStatus into subsonic JukeboxStatus when rendering output. Indexes int64 -> int

* Now we have a position and playing status

* Switching gain to float32, xs:float is defined as 32 bit. Fixing nasty copy/pointer bug

* Now with volume control

* Start working the queue

* Remove user from device interface

* Rename function GetDevice -> GetDeviceForUser to make intention clearer

* Have a nice stringer for the queue

* User Prepared boolean for now to allow pause/unpause

* Skipping works, but without offsets

* Make ChildFromMediaFile public to be used in jukebox get() implementation

* Return position in seconds and implement offset-skip in seconds

* Default offset to 0

* Adding a simple setGain implementation

* Prepare for transcoding AAC

* WIP: transcode to WAV to use beeps wav decoder. Not done yet.

* WIP: out of sheer desparation: convert to MP3 (which works) rather than WAV to troubleshoot issue.

* Use FLAC as intermediate format to play Apple AAC

* A bit of cleanup

* Catching the end-of-stream event for further reactions

* Have a trackSwitching goroutine waiting on channel when track ends

* Move decoder code into own file. Restructure code a bit

* Now with going on to play the next song in the playlist

* Adding shuffle feature

* Implementing remove action

* Cleanup code

* Remove templates for ffmpeg mp3 generation. Not needed anymore.

* Adding some documentation

* Check whether offset into track is in range. Fixing potential remove track bug. Documentation

* Make golangci-lint happy: handling return values

* Adding test suite and example dummy for playback package

* Adding some basic queue tests

* Only use Jukebox.Enabled config option

* Adding stream closing handling

* Pass context.Context to all PlaybackDevice methods

* Remove unneeded function

* Correct spelling

* Reduce visibility of ChildFromMediaFile

* Decomplicate action-parsing

* Adding simple tempfile-based AAC->FLAC transcoding. No parallel reading and writing yet.

* Try to optimize pipe-writing, tempfile-handling and reading. Not done yet.

* Do a synchronous copy of the tempfile. Racecondition detected

* More debugging statements and fixing the play/pause bug. More work needed

* Start the trackSwitcher() with each device once. Return JSON position even if its 0. More debug-output

* Moving all track-handling code into own module

* Fix typo. Do not pass ctx around when not applicable

* WIP: More refactoring, debugging output

* Fix nil pointer

* Repairing MP3 playback by pinning indirect dependencies: hajimehoshi/go-mp3 and hajimehoshi/oto

* Do not forget to cleanup after a skip action

* Make resync with master easy

* Adding missing mocks

* Adding missing error-handling found by linter

* Updating github.com/hajimehoshi/oto

* Removing duplicate function

* Move BEEP-related code into own package

* Juggle beep-related code around as preparation for interface access

* More refactoring for interface separation

* Gather CloseDevice() behind Track interface.

* Adding skeleton, draft audio-interface using mpv.io

* Adding majority of interface commands using messages to mpv socket.

* Adding end-of-stream handling

* MPV: start/stop are working

* postition is given in float in mpv

* Unify Close() and CloseDevice(). Using temp filename for controlling socket

* Wait until control-socket shows up. Cleanup socket in Close()

* Use canceable command. Rename to Executor

* Skipping tracks works now

* Now with actually setting the position

* Fix regain

* Add missing error-handling found by linter

* Adding retry mode on time-pos property getter

* Remove unneeded code on queue

* Putting build-tag beep onto beep files

* Remove deprecated call to rand.Seed()

"As of Go 1.20 there is no reason to call Seed with a random value. Programs that call Seed with a known value to get a specific sequence of results should use New(NewSource(seed)) to obtain a local random generator."

* Using int32 to conform to Subsonic API spec

* Fix merge error

* Minor style changes

* Get username from context

---------

Co-authored-by: Deluan <deluan@navidrome.org>
2026-01-02 20:29:11 +00:00
Deluan
57da35aaaa
Make SmartPlaylists to always be seen as changed for Subsonic clients. 2026-01-02 20:27:26 +00:00
Deluan Quintão
c6e1a78007
Add initial support for OpenSubsonic. (#2302) 2026-01-02 20:25:45 +00:00
Deluan
888d120e12
Fix getSongsByGenre pagination. Fix #1640 2026-01-02 20:25:45 +00:00
Deluan
c816a012b0
Remove any previous UNIX socket file 2026-01-02 20:25:44 +00:00
Deluan
ffb50f50f7
Increase max Server-Sent Events' ID 2026-01-02 20:25:44 +00:00
Deluan
a3f45724a9
Fix lint error 2026-01-02 20:25:44 +00:00
Deluan
a75d8e0c6b
Use channels for EventStream instead of diodes 2026-01-02 20:25:44 +00:00
Deluan
f5eeb03608
Close SSE connection on write error 2026-01-02 20:25:44 +00:00
Deluan
06b9349897
Convert our usage of go-diodes into a simplified, generic version 2026-01-02 20:25:43 +00:00
Deluan
0688ce0d5d
Fix writeEvents race condition.
This required removing the compress middleware from the /events route.
2026-01-02 20:25:43 +00:00
Deluan
2a7c4309a6
Fix race condition 2026-01-02 20:25:43 +00:00
Deluan
4fed55147f
Fix flaky tests 2026-01-02 20:25:33 +00:00
Deluan
58a9ccf00b
Add support for listening on Unix socket.
For that to work, specify the config option `Address` with `unix:/path/to/socket/file`.

Closes #1477
2026-01-02 20:25:33 +00:00
Deluan
b92039b07e
Fix race condition 2026-01-02 20:25:33 +00:00
Deluan
04a42106a5
Fix writeEvent function.
It would not send anything if the `ResponseWriter` was not a `http.Flusher`, and it was leaking channels with `time.After`
2026-01-02 20:25:33 +00:00
Deluan
b8a7e435e0
More tests 2026-01-02 20:25:33 +00:00
Deluan
b6dfcae247
Some refactorings 2026-01-02 20:25:19 +00:00