Merge 348f700a3b409b3f623cc7ee90a2d8ee1b553e28 into 32e1313fc6ddf7100af094d14df13d47735a44bf

ci: bump plugin compilation timeout for regressions (#4690 )
test: update make test-race target to use PKG variable for improved flexibility
2026-05-03 06:51:16 +00:00 · 2025-11-18 01:17:47 +00:00 · 2025-11-16 13:46:32 -05:00 · 2025-11-16 13:41:22 -05:00 · 2025-11-16 12:54:28 -05:00
3 changed files with 6 additions and 2 deletions
--- a/2
+++ b/2
@ -54,7 +54,7 @@ testall: test-race test-i18n test-js ##@Development Run Go and JS tests
 .PHONY: testall

 test-race: ##@Development Run Go tests with race detector
-	go test -tags netgo -race -shuffle=on ./...
+	go test -tags netgo -race -shuffle=on  $(PKG)
 .PHONY: test-race

 test-js: ##@Development Run JS tests
--- a/core/maintenance.go
+++ b/core/maintenance.go
@ -166,7 +166,7 @@ func (s *maintenanceService) getAffectedAlbumIDs(ctx context.Context, ids []stri
 	if len(ids) > 0 {
 		filters = squirrel.And{
 			squirrel.Eq{"missing": true},
-			squirrel.Eq{"id": ids},
+			squirrel.Eq{"media_file.id": ids},
 		}
 	}

--- a/plugins/manager_test.go
+++ b/plugins/manager_test.go
@ -4,6 +4,7 @@ import (
 	"context"
 	"os"
 	"path/filepath"
+	"time"

 	"github.com/navidrome/navidrome/conf"
 	"github.com/navidrome/navidrome/core/agents"
@ -22,8 +23,11 @@ var _ = Describe("Plugin Manager", func() {
 		// but, as this is an integration test, we can't use configtest.SetupConfig() as it causes
 		// data races.
 		originalPluginsFolder := conf.Server.Plugins.Folder
+		originalTimeout := conf.Server.DevPluginCompilationTimeout
+		conf.Server.DevPluginCompilationTimeout = 2 * time.Minute
 		DeferCleanup(func() {
 			conf.Server.Plugins.Folder = originalPluginsFolder
+			conf.Server.DevPluginCompilationTimeout = originalTimeout
 		})
 		conf.Server.Plugins.Enabled = true
 		conf.Server.Plugins.Folder = testDataDir
Author	SHA1	Message	Date
Deluan Quintão	12cddb19a4	Merge 348f700a3b409b3f623cc7ee90a2d8ee1b553e28 into 32e1313fc6ddf7100af094d14df13d47735a44bf	2025-11-18 01:17:47 +00:00
Kendall Garner	32e1313fc6	ci: bump plugin compilation timeout for regressions (#4690 )	2025-11-16 13:46:32 -05:00
Deluan	489d5c7760	test: update make test-race target to use PKG variable for improved flexibility Signed-off-by: Deluan <deluan@navidrome.org>	2025-11-16 13:41:22 -05:00
Kendall Garner	0f1ede2581	fix(scanner): specify exact table to use for missing mediafile filter (#4689 ) In `getAffectedAlbumIDs`, when one or more IDs is added, it adds a filter `"id": ids`. This filter is ambiguous though, because the `getAll` query joins with library table, which _also_ has an `id` field. Clarify this by adding the table name to the filter. Note that this was not caught in testing, as it only uses mock db.	2025-11-16 12:54:28 -05:00