mirror of
https://github.com/navidrome/navidrome.git
synced 2026-08-31 07:30:32 +00:00
* refactor(model): extract canonical 128-bit base62 id codec * feat(model): generate random ids as canonical 128-bit base62 values * feat(scanner): emit legacy PIDs in canonical base62 encoding * feat(db): add id canonicalization transform for the uniform-ids migration * feat(db): migrate all ids to canonical 128-bit base62 encoding * fix(db): canonicalize ids in junction tables and JSON columns * chore(jellyfin): update id-family notes for uniform canonical ids * test(ids): harden codec input contract and migration edge coverage * refactor(model): use log.Fatal for Encode128 contract guard per project convention * fix(db): force full rescan after id migration for legacy PID configs * test(db): guard id-column inventory against schema drift * refactor(ids): compile-time Encode128 contract and unified column rewrite helper * refactor(db): apply review feedback to id migration Filter empty strings in collectColumn's SQL, reuse a prepared statement for rewriteColumn updates, and clarify the legacy ID functions' comment now that they emit the canonical encoding. * feat(auth): split session and public-link JWT secrets, rotating sessions on id migration * test(subsonic): initialize public token secret in helpers suite The suite sets auth.TokenAuth directly instead of calling auth.Init, so the new PublicTokenAuth was nil whenever Ginkgo's spec order ran a helpers spec before any spec that calls auth.Init, panicking in publicurl.ImageURL. * refactor(db): inline canonicalID into its only consumer, the uniform-ids migration * refactor(model): rename Encode128/Decode128 to Encode/Decode With every id now exactly 128 bits, the width suffix is redundant; the package-qualified id.Encode/id.Decode carries the same information. * test(db): make the id-columns guard classify JSON columns too The guard only inspected columns named id/pid/*_id, so it could not see ids embedded in JSON. Widen it to *_ids and to every JSON column, and drive the "covered" set from a new embeddedIDColumns list instead of the inline calls in the migration. Every JSON column the schema has now carries a verdict. The four denormalized caches -- media_file/album.participants, media_file/album.tags, album.folder_ids and artist.similar_artists -- hold only artist, tag and folder ids. Those all come from id.NewHash, whose 22-char base62 encoding of a 128-bit MD5 is already in canonical range, so canonicalID is the identity on them and the migration correctly leaves them alone. A new codec test pins that invariant, since the exemptions depend on it. Verified on a copy of a 727MB/96k-track production database: canonicalizing those four columns changed zero rows, and artist, tag and folder ids were themselves unchanged by the migration (only media_file ids moved, 95108 of 96666).
155 lines
4.5 KiB
Go
155 lines
4.5 KiB
Go
package auth_test
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/navidrome/navidrome/conf"
|
|
"github.com/navidrome/navidrome/consts"
|
|
"github.com/navidrome/navidrome/core/auth"
|
|
"github.com/navidrome/navidrome/log"
|
|
"github.com/navidrome/navidrome/model"
|
|
"github.com/navidrome/navidrome/tests"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
func TestAuth(t *testing.T) {
|
|
log.SetLevel(log.LevelFatal)
|
|
RegisterFailHandler(Fail)
|
|
RunSpecs(t, "Auth Test Suite")
|
|
}
|
|
|
|
const (
|
|
oneDay = 24 * time.Hour
|
|
)
|
|
|
|
var _ = BeforeSuite(func() {
|
|
conf.Server.SessionTimeout = 2 * oneDay
|
|
})
|
|
|
|
var _ = Describe("Auth", func() {
|
|
|
|
BeforeEach(func() {
|
|
ds := &tests.MockDataStore{
|
|
MockedProperty: &tests.MockedPropertyRepo{},
|
|
}
|
|
auth.Init(ds)
|
|
})
|
|
|
|
Describe("Validate", func() {
|
|
It("returns error with an invalid JWT token", func() {
|
|
_, err := auth.Validate("invalid.token")
|
|
Expect(err).To(HaveOccurred())
|
|
})
|
|
|
|
It("returns the claims from a valid JWT token", func() {
|
|
claims := map[string]any{}
|
|
claims["iss"] = "issuer"
|
|
claims["iat"] = time.Now().Unix()
|
|
claims["exp"] = time.Now().Add(1 * time.Minute).Unix()
|
|
_, tokenStr, err := auth.TokenAuth.Encode(claims)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
decodedClaims, err := auth.Validate(tokenStr)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(decodedClaims.Issuer).To(Equal("issuer"))
|
|
})
|
|
|
|
It("returns ErrExpired if the `exp` field is in the past", func() {
|
|
claims := map[string]any{}
|
|
claims["iss"] = "issuer"
|
|
claims["exp"] = time.Now().Add(-1 * time.Minute).Unix()
|
|
_, tokenStr, err := auth.TokenAuth.Encode(claims)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
_, err = auth.Validate(tokenStr)
|
|
Expect(err).To(MatchError("token is expired"))
|
|
})
|
|
})
|
|
|
|
Describe("CreateToken", func() {
|
|
It("creates a valid token", func() {
|
|
u := &model.User{
|
|
ID: "123",
|
|
UserName: "johndoe",
|
|
IsAdmin: true,
|
|
}
|
|
tokenStr, err := auth.CreateToken(u)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
claims, err := auth.Validate(tokenStr)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
Expect(claims.Issuer).To(Equal(consts.JWTIssuer))
|
|
Expect(claims.Subject).To(Equal("johndoe"))
|
|
Expect(claims.UserID).To(Equal("123"))
|
|
Expect(claims.IsAdmin).To(Equal(true))
|
|
Expect(claims.ExpiresAt).To(BeTemporally(">", time.Now()))
|
|
})
|
|
})
|
|
|
|
Describe("Session/Public secret split", func() {
|
|
claims := func() map[string]any {
|
|
return map[string]any{"iss": "issuer", "exp": time.Now().Add(1 * time.Minute).Unix()}
|
|
}
|
|
|
|
It("verifies a session token via Validate but not ValidatePublic", func() {
|
|
_, tokenStr, err := auth.TokenAuth.Encode(claims())
|
|
Expect(err).NotTo(HaveOccurred())
|
|
_, err = auth.Validate(tokenStr)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
_, err = auth.ValidatePublic(tokenStr)
|
|
Expect(err).To(HaveOccurred())
|
|
})
|
|
|
|
It("verifies a public token via ValidatePublic but not Validate", func() {
|
|
_, tokenStr, err := auth.PublicTokenAuth.Encode(claims())
|
|
Expect(err).NotTo(HaveOccurred())
|
|
_, err = auth.ValidatePublic(tokenStr)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
_, err = auth.Validate(tokenStr)
|
|
Expect(err).To(HaveOccurred())
|
|
})
|
|
|
|
It("decodes public tokens minted by CreatePublicToken via PublicTokenAuth", func() {
|
|
tokenStr, err := auth.CreatePublicToken(auth.Claims{ID: "art-1"})
|
|
Expect(err).NotTo(HaveOccurred())
|
|
claims, err := auth.ValidatePublic(tokenStr)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(claims.ID).To(Equal("art-1"))
|
|
_, err = auth.Validate(tokenStr)
|
|
Expect(err).To(HaveOccurred())
|
|
})
|
|
|
|
It("decodes expiring public tokens minted by CreateExpiringPublicToken via PublicTokenAuth", func() {
|
|
exp := time.Now().Add(1 * time.Hour)
|
|
tokenStr, err := auth.CreateExpiringPublicToken(exp, auth.Claims{ID: "art-2"})
|
|
Expect(err).NotTo(HaveOccurred())
|
|
claims, err := auth.ValidatePublic(tokenStr)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(claims.ID).To(Equal("art-2"))
|
|
_, err = auth.Validate(tokenStr)
|
|
Expect(err).To(HaveOccurred())
|
|
})
|
|
})
|
|
|
|
Describe("TouchToken", func() {
|
|
It("updates the expiration time", func() {
|
|
yesterday := time.Now().Add(-oneDay)
|
|
claims := map[string]any{}
|
|
claims["iss"] = "issuer"
|
|
claims["exp"] = yesterday.Unix()
|
|
token, _, err := auth.TokenAuth.Encode(claims)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
touched, err := auth.TouchToken(token)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
decodedClaims, err := auth.Validate(touched)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(decodedClaims.ExpiresAt.Sub(yesterday)).To(BeNumerically(">=", oneDay))
|
|
})
|
|
})
|
|
})
|