mirror of
https://github.com/navidrome/navidrome.git
synced 2026-08-31 07:30:32 +00:00
fc1c1366dc
The export path used the `println` builtin, which writes to stderr, so `navidrome pls -p X > playlist.m3u8` produced an empty file while the M3U body was interleaved with the startup logs on stderr. `println` also appended a newline that `ToM3U8` already provides, so the piped output had a stray trailing blank line that `-o file` did not. Both destinations are now byte-identical. The stdout/file choice moved into a `writePlaylist` helper shared by `pls -p` and `pls export -p`, which both had the same bug. It takes the destination as an `io.Writer`, matching the existing convention in cmd/artwork.go.
36 lines
903 B
Go
36 lines
903 B
Go
package cmd
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("writePlaylist", func() {
|
|
const m3u = "#EXTM3U\n#PLAYLIST:DJ Wave\n#EXTINF:364,Bel Canto - Dreaming Girl\n"
|
|
plsFile := filepath.Join(os.TempDir(), fmt.Sprintf("navidrome-pls-%d.m3u8", os.Getpid()))
|
|
|
|
BeforeEach(func() {
|
|
DeferCleanup(func() { _ = os.Remove(plsFile) })
|
|
})
|
|
|
|
DescribeTable("writes the playlist to exactly one destination",
|
|
func(file, wantStream, wantFile string) {
|
|
var out strings.Builder
|
|
|
|
writePlaylist(m3u, &out, file)
|
|
|
|
written, _ := os.ReadFile(plsFile)
|
|
Expect(out.String()).To(Equal(wantStream))
|
|
Expect(string(written)).To(Equal(wantFile))
|
|
},
|
|
Entry("no file name writes to the stream", "", m3u, ""),
|
|
Entry("a dash writes to the stream", "-", m3u, ""),
|
|
Entry("a path writes to the file", plsFile, "", m3u),
|
|
)
|
|
})
|