mirror of
https://github.com/navidrome/navidrome.git
synced 2026-08-31 07:30:32 +00:00
f853ca604a
* refactor(model): extract canonical 128-bit base62 id codec * feat(model): generate random ids as canonical 128-bit base62 values * feat(scanner): emit legacy PIDs in canonical base62 encoding * feat(db): add id canonicalization transform for the uniform-ids migration * feat(db): migrate all ids to canonical 128-bit base62 encoding * fix(db): canonicalize ids in junction tables and JSON columns * chore(jellyfin): update id-family notes for uniform canonical ids * test(ids): harden codec input contract and migration edge coverage * refactor(model): use log.Fatal for Encode128 contract guard per project convention * fix(db): force full rescan after id migration for legacy PID configs * test(db): guard id-column inventory against schema drift * refactor(ids): compile-time Encode128 contract and unified column rewrite helper * refactor(db): apply review feedback to id migration Filter empty strings in collectColumn's SQL, reuse a prepared statement for rewriteColumn updates, and clarify the legacy ID functions' comment now that they emit the canonical encoding. * feat(auth): split session and public-link JWT secrets, rotating sessions on id migration * test(subsonic): initialize public token secret in helpers suite The suite sets auth.TokenAuth directly instead of calling auth.Init, so the new PublicTokenAuth was nil whenever Ginkgo's spec order ran a helpers spec before any spec that calls auth.Init, panicking in publicurl.ImageURL. * refactor(db): inline canonicalID into its only consumer, the uniform-ids migration * refactor(model): rename Encode128/Decode128 to Encode/Decode With every id now exactly 128 bits, the width suffix is redundant; the package-qualified id.Encode/id.Decode carries the same information. * test(db): make the id-columns guard classify JSON columns too The guard only inspected columns named id/pid/*_id, so it could not see ids embedded in JSON. Widen it to *_ids and to every JSON column, and drive the "covered" set from a new embeddedIDColumns list instead of the inline calls in the migration. Every JSON column the schema has now carries a verdict. The four denormalized caches -- media_file/album.participants, media_file/album.tags, album.folder_ids and artist.similar_artists -- hold only artist, tag and folder ids. Those all come from id.NewHash, whose 22-char base62 encoding of a 128-bit MD5 is already in canonical range, so canonicalID is the identity on them and the migration correctly leaves them alone. A new codec test pins that invariant, since the exemptions depend on it. Verified on a copy of a 727MB/96k-track production database: canonicalizing those four columns changed zero rows, and artist, tag and folder ids were themselves unchanged by the migration (only media_file ids moved, 95108 of 96666).
61 lines
1.6 KiB
Go
61 lines
1.6 KiB
Go
package metadata
|
|
|
|
import (
|
|
"cmp"
|
|
"crypto/md5"
|
|
"fmt"
|
|
"strings"
|
|
|
|
"github.com/navidrome/navidrome/conf"
|
|
"github.com/navidrome/navidrome/consts"
|
|
"github.com/navidrome/navidrome/model"
|
|
"github.com/navidrome/navidrome/model/id"
|
|
)
|
|
|
|
// These legacy ID functions hash the same inputs as the original Navidrome ID generation,
|
|
// now emitted in the canonical base62 encoding (matching what the uniform-ids migration stores).
|
|
|
|
func legacyTrackID(mf model.MediaFile, prependLibId bool) string {
|
|
key := mf.Path
|
|
if prependLibId && mf.LibraryID != model.DefaultLibraryID {
|
|
key = fmt.Sprintf("%d\\%s", mf.LibraryID, key)
|
|
}
|
|
sum := md5.Sum([]byte(key))
|
|
return id.Encode(sum)
|
|
}
|
|
|
|
func legacyAlbumID(mf model.MediaFile, md Metadata, prependLibId bool) string {
|
|
_, _, releaseDate := md.mapDates()
|
|
albumPath := strings.ToLower(fmt.Sprintf("%s\\%s", legacyMapAlbumArtistName(md), legacyMapAlbumName(md)))
|
|
if !conf.Server.Scanner.GroupAlbumReleases {
|
|
if len(releaseDate) != 0 {
|
|
albumPath = fmt.Sprintf("%s\\%s", albumPath, releaseDate)
|
|
}
|
|
}
|
|
if prependLibId && mf.LibraryID != model.DefaultLibraryID {
|
|
albumPath = fmt.Sprintf("%d\\%s", mf.LibraryID, albumPath)
|
|
}
|
|
sum := md5.Sum([]byte(albumPath))
|
|
return id.Encode(sum)
|
|
}
|
|
|
|
func legacyMapAlbumArtistName(md Metadata) string {
|
|
values := []string{
|
|
md.String(model.TagAlbumArtist),
|
|
"",
|
|
md.String(model.TagTrackArtist),
|
|
consts.UnknownArtist,
|
|
}
|
|
if md.Bool(model.TagCompilation) {
|
|
values[1] = consts.VariousArtists
|
|
}
|
|
return cmp.Or(values...)
|
|
}
|
|
|
|
func legacyMapAlbumName(md Metadata) string {
|
|
return cmp.Or(
|
|
md.String(model.TagAlbum),
|
|
consts.UnknownAlbum,
|
|
)
|
|
}
|