mirror of
https://github.com/navidrome/navidrome.git
synced 2026-08-01 07:21:17 +00:00
9ce51cf575
Backfill enumerated every album, artist, playlist and radio via GetAll and mapped out just the ID. GetAll materializes full entities (library joins, participant/stats/tags JSON, annotation, artwork hydration), so on a large library it loaded tens of thousands of heavy structs only to read one field each — spiking transient RSS to ~1GB during the one-time upgrade backfill, a memory risk on small NAS/Pi hardware. Add GetAllIDs to the album, artist, playlist and radio repositories: it reuses each repo's base row-set filter (library visibility, artist content join, playlist userFilter) but projects only id, skipping the heavy columns and post-processing. A per-repo parity test asserts GetAllIDs returns exactly the same id set as GetAll. Verified on a 727MB / 29k-artist production DB copy: peak RSS during backfill dropped from ~1012MB to ~89MB, file descriptors flat, same 36,138 items enqueued.
103 lines
3.2 KiB
Go
103 lines
3.2 KiB
Go
package model
|
|
|
|
import (
|
|
"iter"
|
|
"maps"
|
|
"slices"
|
|
"time"
|
|
|
|
"github.com/navidrome/navidrome/consts"
|
|
)
|
|
|
|
type Artist struct {
|
|
Annotations `structs:"-"`
|
|
|
|
ID string `structs:"id" json:"id"`
|
|
|
|
// Data based on tags
|
|
Name string `structs:"name" json:"name"`
|
|
SortArtistName string `structs:"sort_artist_name" json:"sortArtistName,omitempty"`
|
|
OrderArtistName string `structs:"order_artist_name" json:"orderArtistName,omitempty"`
|
|
MbzArtistID string `structs:"mbz_artist_id" json:"mbzArtistId,omitempty"`
|
|
|
|
// Data calculated from files
|
|
Stats map[Role]ArtistStats `structs:"-" json:"stats,omitempty"`
|
|
Size int64 `structs:"-" json:"size,omitempty"`
|
|
AlbumCount int `structs:"-" json:"albumCount,omitempty"`
|
|
SongCount int `structs:"-" json:"songCount,omitempty"`
|
|
|
|
// Data imported from external sources
|
|
Biography string `structs:"biography" json:"biography,omitempty"`
|
|
SmallImageUrl string `structs:"small_image_url" json:"smallImageUrl,omitempty"`
|
|
MediumImageUrl string `structs:"medium_image_url" json:"mediumImageUrl,omitempty"`
|
|
LargeImageUrl string `structs:"large_image_url" json:"largeImageUrl,omitempty"`
|
|
ExternalUrl string `structs:"external_url" json:"externalUrl,omitempty"`
|
|
SimilarArtists Artists `structs:"similar_artists" json:"-"`
|
|
ExternalInfoUpdatedAt *time.Time `structs:"external_info_updated_at" json:"externalInfoUpdatedAt,omitempty"`
|
|
|
|
Missing bool `structs:"missing" json:"missing"`
|
|
|
|
UploadedImage string `structs:"uploaded_image" json:"uploadedImage,omitempty"`
|
|
|
|
CreatedAt *time.Time `structs:"created_at" json:"createdAt,omitempty"`
|
|
UpdatedAt *time.Time `structs:"updated_at" json:"updatedAt,omitempty"`
|
|
}
|
|
|
|
type ArtistStats struct {
|
|
SongCount int `json:"songCount"`
|
|
AlbumCount int `json:"albumCount"`
|
|
Size int64 `json:"size"`
|
|
}
|
|
|
|
func (a Artist) ArtistImageUrl() string {
|
|
if a.LargeImageUrl != "" {
|
|
return a.LargeImageUrl
|
|
}
|
|
if a.MediumImageUrl != "" {
|
|
return a.MediumImageUrl
|
|
}
|
|
return a.SmallImageUrl
|
|
}
|
|
|
|
func (a Artist) CoverArtID() ArtworkID {
|
|
return artworkIDFromArtist(a)
|
|
}
|
|
|
|
func (a Artist) UploadedImagePath() string {
|
|
return UploadedImagePath(consts.EntityArtist, a.UploadedImage)
|
|
}
|
|
|
|
// Roles returns the roles this artist has participated in., based on the Stats field
|
|
func (a Artist) Roles() []Role {
|
|
return slices.Collect(maps.Keys(a.Stats))
|
|
}
|
|
|
|
type Artists []Artist
|
|
|
|
type ArtistIndex struct {
|
|
ID string
|
|
Artists Artists
|
|
}
|
|
type ArtistIndexes []ArtistIndex
|
|
|
|
type ArtistCursor iter.Seq2[Artist, error]
|
|
|
|
type ArtistRepository interface {
|
|
CountAll(options ...QueryOptions) (int64, error)
|
|
Exists(id string) (bool, error)
|
|
Put(m *Artist, colsToUpdate ...string) error
|
|
UpdateExternalInfo(a *Artist) error
|
|
Get(id string) (*Artist, error)
|
|
GetAll(options ...QueryOptions) (Artists, error)
|
|
GetAllIDs(options ...QueryOptions) ([]string, error)
|
|
GetCursor(options ...QueryOptions) (ArtistCursor, error)
|
|
GetIndex(includeMissing bool, libraryIds []int, roles ...Role) (ArtistIndexes, error)
|
|
|
|
// The following methods are used exclusively by the scanner:
|
|
RefreshPlayCounts() (int64, error)
|
|
RefreshStats(allArtists bool) (int64, error)
|
|
|
|
AnnotatedRepository
|
|
SearchableRepository[Artists]
|
|
}
|