mirror of
https://github.com/navidrome/navidrome.git
synced 2026-08-31 07:30:32 +00:00
Backfill enumerated every album, artist, playlist and radio via GetAll and mapped out just the ID. GetAll materializes full entities (library joins, participant/stats/tags JSON, annotation, artwork hydration), so on a large library it loaded tens of thousands of heavy structs only to read one field each — spiking transient RSS to ~1GB during the one-time upgrade backfill, a memory risk on small NAS/Pi hardware. Add GetAllIDs to the album, artist, playlist and radio repositories: it reuses each repo's base row-set filter (library visibility, artist content join, playlist userFilter) but projects only id, skipping the heavy columns and post-processing. A per-repo parity test asserts GetAllIDs returns exactly the same id set as GetAll. Verified on a 727MB / 29k-artist production DB copy: peak RSS during backfill dropped from ~1012MB to ~89MB, file descriptors flat, same 36,138 items enqueued.
144 lines
3.6 KiB
Go
144 lines
3.6 KiB
Go
package persistence
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"time"
|
|
|
|
. "github.com/Masterminds/squirrel"
|
|
"github.com/deluan/rest"
|
|
"github.com/navidrome/navidrome/log"
|
|
"github.com/navidrome/navidrome/model"
|
|
"github.com/navidrome/navidrome/model/id"
|
|
"github.com/pocketbase/dbx"
|
|
)
|
|
|
|
type radioRepository struct {
|
|
sqlRepository
|
|
}
|
|
|
|
func NewRadioRepository(ctx context.Context, db dbx.Builder) model.RadioRepository {
|
|
r := &radioRepository{}
|
|
r.ctx = ctx
|
|
r.db = db
|
|
r.registerModel(&model.Radio{}, map[string]filterFunc{
|
|
"name": containsFilter("name"),
|
|
})
|
|
return r
|
|
}
|
|
|
|
func (r *radioRepository) isPermitted() bool {
|
|
user := loggedUser(r.ctx)
|
|
return user.IsAdmin
|
|
}
|
|
|
|
func (r *radioRepository) CountAll(options ...model.QueryOptions) (int64, error) {
|
|
sql := r.newSelect()
|
|
return r.count(sql, options...)
|
|
}
|
|
|
|
func (r *radioRepository) Delete(id string) error {
|
|
if !r.isPermitted() {
|
|
return rest.ErrPermissionDenied
|
|
}
|
|
|
|
return r.delete(Eq{"id": id})
|
|
}
|
|
|
|
func (r *radioRepository) Get(id string) (*model.Radio, error) {
|
|
sel := r.newSelect().Where(Eq{"id": id}).Columns("*")
|
|
res := model.Radio{}
|
|
err := r.queryOne(sel, &res)
|
|
return &res, err
|
|
}
|
|
|
|
func (r *radioRepository) GetAll(options ...model.QueryOptions) (model.Radios, error) {
|
|
sel := r.newSelect(options...).Columns("*")
|
|
res := model.Radios{}
|
|
err := r.queryAll(sel, &res)
|
|
return res, err
|
|
}
|
|
|
|
// GetAllIDs returns just the radio IDs. Used by bulk enumeration (artwork backfill).
|
|
func (r *radioRepository) GetAllIDs(options ...model.QueryOptions) ([]string, error) {
|
|
sel := r.newSelect(options...).Columns("id")
|
|
ids := []string{}
|
|
err := r.queryAllSlice(sel, &ids)
|
|
return ids, err
|
|
}
|
|
|
|
func (r *radioRepository) Put(radio *model.Radio, colsToUpdate ...string) error {
|
|
if !r.isPermitted() {
|
|
return rest.ErrPermissionDenied
|
|
}
|
|
|
|
radio.UpdatedAt = time.Now()
|
|
if radio.ID == "" {
|
|
radio.CreatedAt = time.Now()
|
|
radio.ID = id.NewRandom()
|
|
}
|
|
if len(colsToUpdate) > 0 {
|
|
colsToUpdate = append(colsToUpdate, "UpdatedAt")
|
|
}
|
|
_, err := r.put(radio.ID, radio, colsToUpdate...)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
// Enqueue artwork resolution for the created/updated radio. Never fails the save.
|
|
item := model.ArtworkQueueItem{ItemKind: "ra", ItemID: radio.ID, ImageType: model.ImageTypePrimary,
|
|
Priority: model.ArtworkPriorityScan}
|
|
if err := NewArtworkQueueRepository(r.ctx, r.db).Enqueue(item); err != nil {
|
|
log.Warn(r.ctx, "could not enqueue radio artwork", "id", radio.ID, err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (r *radioRepository) Count(options ...rest.QueryOptions) (int64, error) {
|
|
return r.CountAll(r.parseRestOptions(r.ctx, options...))
|
|
}
|
|
|
|
func (r *radioRepository) EntityName() string {
|
|
return "radio"
|
|
}
|
|
|
|
func (r *radioRepository) NewInstance() any {
|
|
return &model.Radio{}
|
|
}
|
|
|
|
func (r *radioRepository) Read(id string) (any, error) {
|
|
return r.Get(id)
|
|
}
|
|
|
|
func (r *radioRepository) ReadAll(options ...rest.QueryOptions) (any, error) {
|
|
return r.GetAll(r.parseRestOptions(r.ctx, options...))
|
|
}
|
|
|
|
func (r *radioRepository) Save(entity any) (string, error) {
|
|
t := entity.(*model.Radio)
|
|
if !r.isPermitted() {
|
|
return "", rest.ErrPermissionDenied
|
|
}
|
|
err := r.Put(t)
|
|
if errors.Is(err, model.ErrNotFound) {
|
|
return "", rest.ErrNotFound
|
|
}
|
|
return t.ID, err
|
|
}
|
|
|
|
func (r *radioRepository) Update(id string, entity any, cols ...string) error {
|
|
t := entity.(*model.Radio)
|
|
t.ID = id
|
|
if !r.isPermitted() {
|
|
return rest.ErrPermissionDenied
|
|
}
|
|
err := r.Put(t)
|
|
if errors.Is(err, model.ErrNotFound) {
|
|
return rest.ErrNotFound
|
|
}
|
|
return err
|
|
}
|
|
|
|
var _ model.RadioRepository = (*radioRepository)(nil)
|
|
var _ rest.Repository = (*radioRepository)(nil)
|
|
var _ rest.Persistable = (*radioRepository)(nil)
|