mirror of
https://github.com/navidrome/navidrome.git
synced 2026-08-01 07:21:17 +00:00
593b5db8e9
Extracted inline deletion logic from server/nativeapi/missing.go into a new core.MissingFiles service interface and implementation. This provides better separation of concerns and testability. The MissingFiles service handles: - Deletion of specific or all missing files via transaction - Garbage collection after deletion - Extraction of affected album IDs from missing files - Background refresh of artist and album statistics The deleteMissingFiles HTTP handler now simply delegates to the service, removing 70+ lines of inline logic. All deletion, transaction, and stat refresh logic is now centralized in core/missing_files.go. Updated dependency injection to provide MissingFiles service to the native API router. Renamed receiver variable from 'n' to 'api' throughout native_api.go for consistency.
102 lines
3.0 KiB
Go
102 lines
3.0 KiB
Go
package nativeapi
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"net/http"
|
|
|
|
"github.com/go-chi/chi/v5"
|
|
"github.com/navidrome/navidrome/core"
|
|
"github.com/navidrome/navidrome/log"
|
|
"github.com/navidrome/navidrome/model"
|
|
)
|
|
|
|
// User-library association endpoints (admin only)
|
|
func (api *Router) addUserLibraryRoute(r chi.Router) {
|
|
r.Route("/user/{id}/library", func(r chi.Router) {
|
|
r.Use(parseUserIDMiddleware)
|
|
r.Get("/", getUserLibraries(api.libs))
|
|
r.Put("/", setUserLibraries(api.libs))
|
|
})
|
|
}
|
|
|
|
// Middleware to parse user ID from URL
|
|
func parseUserIDMiddleware(next http.Handler) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
userID := chi.URLParam(r, "id")
|
|
if userID == "" {
|
|
http.Error(w, "Invalid user ID", http.StatusBadRequest)
|
|
return
|
|
}
|
|
ctx := context.WithValue(r.Context(), "userID", userID)
|
|
next.ServeHTTP(w, r.WithContext(ctx))
|
|
})
|
|
}
|
|
|
|
// User-library association handlers
|
|
|
|
func getUserLibraries(service core.Library) http.HandlerFunc {
|
|
return func(w http.ResponseWriter, r *http.Request) {
|
|
userID := r.Context().Value("userID").(string)
|
|
|
|
libraries, err := service.GetUserLibraries(r.Context(), userID)
|
|
if err != nil {
|
|
if errors.Is(err, model.ErrNotFound) {
|
|
http.Error(w, "User not found", http.StatusNotFound)
|
|
return
|
|
}
|
|
log.Error(r.Context(), "Error getting user libraries", "userID", userID, err)
|
|
http.Error(w, "Internal server error", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
|
|
w.Header().Set("Content-Type", "application/json")
|
|
if err := json.NewEncoder(w).Encode(libraries); err != nil {
|
|
log.Error(r.Context(), "Error encoding user libraries response", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func setUserLibraries(service core.Library) http.HandlerFunc {
|
|
return func(w http.ResponseWriter, r *http.Request) {
|
|
userID := r.Context().Value("userID").(string)
|
|
|
|
var request struct {
|
|
LibraryIDs []int `json:"libraryIds"`
|
|
}
|
|
if err := json.NewDecoder(r.Body).Decode(&request); err != nil {
|
|
log.Error(r.Context(), "Error decoding request", err)
|
|
http.Error(w, "Invalid request body", http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
if err := service.SetUserLibraries(r.Context(), userID, request.LibraryIDs); err != nil {
|
|
log.Error(r.Context(), "Error setting user libraries", "userID", userID, err)
|
|
if errors.Is(err, model.ErrNotFound) {
|
|
http.Error(w, "User not found", http.StatusNotFound)
|
|
return
|
|
}
|
|
if errors.Is(err, model.ErrValidation) {
|
|
http.Error(w, err.Error(), http.StatusBadRequest)
|
|
return
|
|
}
|
|
http.Error(w, "Failed to set user libraries", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
|
|
// Return updated user libraries
|
|
libraries, err := service.GetUserLibraries(r.Context(), userID)
|
|
if err != nil {
|
|
log.Error(r.Context(), "Error getting updated user libraries", "userID", userID, err)
|
|
http.Error(w, "Internal server error", http.StatusInternalServerError)
|
|
return
|
|
}
|
|
|
|
w.Header().Set("Content-Type", "application/json")
|
|
if err := json.NewEncoder(w).Encode(libraries); err != nil {
|
|
log.Error(r.Context(), "Error encoding user libraries response", err)
|
|
}
|
|
}
|
|
}
|