mirror of
https://github.com/navidrome/navidrome.git
synced 2026-05-03 06:51:16 +00:00
251cc71e2d
* refactor: move criteria SQL generation to persistence Keep model/criteria as a domain DSL with JSON parsing, field metadata, expression traversal, and child playlist extraction only. Move smart playlist SQL translation, sort SQL, and join planning into persistence behind smartPlaylistCriteria so repository code uses a small query-building API. * refactor: simplify criteria translator metadata Use generic helper functions for criteria operator maps so the SQL translator can pass named criteria map types directly. Remove unused pseudo-field metadata from the criteria field API while preserving special field name lookup. * test: add coverage check for criteria-to-SQL field mappings Add a test that iterates all fields registered in the criteria package and verifies that every non-tag/non-role field has a corresponding entry in the persistence layer's smartPlaylistFields map. This prevents silent drift between the domain field registry and the SQL translation layer. Also adds an AllFieldNames() function to the criteria package to support field enumeration from outside the package.
64 lines
1.7 KiB
Go
64 lines
1.7 KiB
Go
package criteria
|
|
|
|
import (
|
|
. "github.com/onsi/ginkgo/v2"
|
|
"github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("fields", func() {
|
|
Describe("LookupField", func() {
|
|
It("finds built-in fields case-insensitively", func() {
|
|
field, ok := LookupField("Title")
|
|
|
|
gomega.Expect(ok).To(gomega.BeTrue())
|
|
gomega.Expect(field).To(gomega.Equal(FieldInfo{Name: "title"}))
|
|
})
|
|
|
|
It("resolves aliases to their semantic field name", func() {
|
|
field, ok := LookupField("albumtype")
|
|
|
|
gomega.Expect(ok).To(gomega.BeTrue())
|
|
gomega.Expect(field.Name).To(gomega.Equal("releasetype"))
|
|
gomega.Expect(field.IsTag).To(gomega.BeTrue())
|
|
})
|
|
|
|
It("finds special fields", func() {
|
|
field, ok := LookupField("value")
|
|
|
|
gomega.Expect(ok).To(gomega.BeTrue())
|
|
gomega.Expect(field.Name).To(gomega.Equal("value"))
|
|
})
|
|
|
|
It("finds registered tag names", func() {
|
|
AddTagNames([]string{"task3_mood"})
|
|
|
|
field, ok := LookupField("task3_mood")
|
|
|
|
gomega.Expect(ok).To(gomega.BeTrue())
|
|
gomega.Expect(field.Name).To(gomega.Equal("task3_mood"))
|
|
gomega.Expect(field.IsTag).To(gomega.BeTrue())
|
|
})
|
|
|
|
It("marks registered numeric tags", func() {
|
|
AddTagNames([]string{"task3_score"})
|
|
AddNumericTags([]string{"task3_score"})
|
|
|
|
field, ok := LookupField("task3_score")
|
|
|
|
gomega.Expect(ok).To(gomega.BeTrue())
|
|
gomega.Expect(field.IsTag).To(gomega.BeTrue())
|
|
gomega.Expect(field.Numeric).To(gomega.BeTrue())
|
|
})
|
|
|
|
It("finds registered roles", func() {
|
|
AddRoles([]string{"task3_producer"})
|
|
|
|
field, ok := LookupField("task3_producer")
|
|
|
|
gomega.Expect(ok).To(gomega.BeTrue())
|
|
gomega.Expect(field.Name).To(gomega.Equal("task3_producer"))
|
|
gomega.Expect(field.IsRole).To(gomega.BeTrue())
|
|
})
|
|
})
|
|
})
|