mirror of
https://github.com/navidrome/navidrome.git
synced 2026-06-02 07:01:36 +00:00
* feat(plugins): add PlaybackReport to Scrobbler interface and all implementations * feat(plugins): add PlaybackReport worker and dispatch in PlayTracker * feat(plugins): add PlaybackReportRequest to plugin scrobbler capability * chore(plugins): regenerate PDK files with PlaybackReport * feat(plugins): add PlaybackReport to test scrobbler plugin * feat(plugins): add PlaybackReport to plugin scrobbler adapter * refactor(plugins): fix double DB fetch in StateStopped and batch getActiveScrobblers - Hoist mf from scrobble branch so PlaybackReport reuses it instead of fetching again from DB - Call getActiveScrobblers once per drain batch instead of per-entry * chore(plugins): include generated scrobbler schema with PlaybackReport * fix(plugins): skip PlaybackReport for plugins that don't export it Plugins detected as scrobblers only need to export one scrobbler function. Older plugins that don't export nd_scrobbler_playback_report would cause noisy error logs on every reportPlayback call. Now errFunctionNotFound and errNotImplemented are treated as no-ops. * refactor: rename NowPlayingInfo to PlaybackReport Signed-off-by: Deluan <deluan@navidrome.org> * refactor: rename stopNowPlayingWorker to stopBackgroundWorkers Signed-off-by: Deluan <deluan@navidrome.org> * refactor: move NowPlaying and PlaybackReport logic to separate worker files Signed-off-by: Deluan <deluan@navidrome.org> * refactor(scrobbler): rename NowPlayingInfo to PlaybackSession and add expired state Rename NowPlayingInfo struct to PlaybackSession to better reflect its role as a complete playback session representation. Add UserId field to make sessions self-contained, removing redundant userId parameters from PlaybackReport interface method and internal dispatch functions. Introduce StateExpired internal state that fires when a session cache entry expires without an explicit stop, ensuring plugins always receive a terminal event regardless of client behavior. * fix(scrobbler): update playback state description to include 'expired' Signed-off-by: Deluan <deluan@navidrome.org> * fix(scrobbler): resolve data race in OnExpiration callback Capture conf.Server.EnableNowPlaying at construction time instead of reading it from the background ttlcache eviction goroutine. The previous code raced with test config cleanup that writes to the same field concurrently. * fix(scrobbler): return error when media file lookup fails in StateStopped Simplify the MediaFile population logic in the stopped case to return an error if the track cannot be found. A stop report with an empty MediaFile is useless to plugins, and returning the error allows clients to retry or alert the user when auto-scrobble is enabled. * refactor(scrobbler): use session data directly in PlaybackReport adapter Use info.Username from PlaybackSession instead of extracting it from context in the plugin adapter, since the session is now self-contained. Add debug/trace logging for session expiration and enqueue the expired report with a user-enriched context so downstream handlers can identify the user. --------- Signed-off-by: Deluan <deluan@navidrome.org>
137 lines
5.4 KiB
Go
137 lines
5.4 KiB
Go
package capabilities
|
|
|
|
// Scrobbler provides scrobbling functionality to external services.
|
|
// This capability allows plugins to submit listening history to services like Last.fm,
|
|
// ListenBrainz, or custom scrobbling backends.
|
|
//
|
|
// All methods are required - plugins implementing this capability must provide
|
|
// all four functions: IsAuthorized, NowPlaying, Scrobble, and PlaybackReport.
|
|
//
|
|
//nd:capability name=scrobbler required=true
|
|
type Scrobbler interface {
|
|
// IsAuthorized checks if a user is authorized to scrobble to this service.
|
|
//nd:export name=nd_scrobbler_is_authorized
|
|
IsAuthorized(IsAuthorizedRequest) (bool, error)
|
|
|
|
// NowPlaying sends a now playing notification to the scrobbling service.
|
|
//nd:export name=nd_scrobbler_now_playing
|
|
NowPlaying(NowPlayingRequest) error
|
|
|
|
// Scrobble submits a completed scrobble to the scrobbling service.
|
|
//nd:export name=nd_scrobbler_scrobble
|
|
Scrobble(ScrobbleRequest) error
|
|
|
|
// PlaybackReport sends a playback state report to the scrobbling service.
|
|
//nd:export name=nd_scrobbler_playback_report
|
|
PlaybackReport(PlaybackReportRequest) error
|
|
}
|
|
|
|
// IsAuthorizedRequest is the request for authorization check.
|
|
type IsAuthorizedRequest struct {
|
|
// Username is the username of the user.
|
|
Username string `json:"username"`
|
|
}
|
|
|
|
// ArtistRef is a reference to an artist with name and optional MBID.
|
|
type ArtistRef struct {
|
|
// ID is the internal Navidrome artist ID (if known).
|
|
ID string `json:"id,omitempty"`
|
|
// Name is the artist name.
|
|
Name string `json:"name"`
|
|
// MBID is the MusicBrainz ID for the artist.
|
|
MBID string `json:"mbid,omitempty"`
|
|
}
|
|
|
|
// TrackInfo contains track metadata.
|
|
type TrackInfo struct {
|
|
// ID is the internal Navidrome track ID.
|
|
ID string `json:"id"`
|
|
// Title is the track title.
|
|
Title string `json:"title"`
|
|
// Album is the album name.
|
|
Album string `json:"album"`
|
|
// Artist is the formatted artist name for display (e.g., "Artist1 • Artist2").
|
|
Artist string `json:"artist"`
|
|
// AlbumArtist is the formatted album artist name for display.
|
|
AlbumArtist string `json:"albumArtist"`
|
|
// Artists is the list of track artists.
|
|
Artists []ArtistRef `json:"artists"`
|
|
// AlbumArtists is the list of album artists.
|
|
AlbumArtists []ArtistRef `json:"albumArtists"`
|
|
// Duration is the track duration in seconds.
|
|
Duration float32 `json:"duration"`
|
|
// TrackNumber is the track number on the album.
|
|
TrackNumber int32 `json:"trackNumber"`
|
|
// DiscNumber is the disc number.
|
|
DiscNumber int32 `json:"discNumber"`
|
|
// MBZRecordingID is the MusicBrainz recording ID.
|
|
MBZRecordingID string `json:"mbzRecordingId,omitempty"`
|
|
// MBZAlbumID is the MusicBrainz album/release ID.
|
|
MBZAlbumID string `json:"mbzAlbumId,omitempty"`
|
|
// MBZReleaseGroupID is the MusicBrainz release group ID.
|
|
MBZReleaseGroupID string `json:"mbzReleaseGroupId,omitempty"`
|
|
// MBZReleaseTrackID is the MusicBrainz release track ID.
|
|
MBZReleaseTrackID string `json:"mbzReleaseTrackId,omitempty"`
|
|
// LibraryID is the ID of the library the track belongs to.
|
|
// Only included if the plugin has library permission with filesystem access for the track's library.
|
|
LibraryID int32 `json:"libraryId,omitempty"`
|
|
// Path is the full path to the track file, relative to the library root.
|
|
// Only included if the plugin has library permission with filesystem access for the track's library.
|
|
Path string `json:"path,omitempty"`
|
|
}
|
|
|
|
// NowPlayingRequest is the request for now playing notification.
|
|
type NowPlayingRequest struct {
|
|
// Username is the username of the user.
|
|
Username string `json:"username"`
|
|
// Track is the track currently playing.
|
|
Track TrackInfo `json:"track"`
|
|
// Position is the current playback position in seconds.
|
|
Position int32 `json:"position"`
|
|
}
|
|
|
|
// ScrobbleRequest is the request for submitting a scrobble.
|
|
type ScrobbleRequest struct {
|
|
// Username is the username of the user.
|
|
Username string `json:"username"`
|
|
// Track is the track that was played.
|
|
Track TrackInfo `json:"track"`
|
|
// Timestamp is the Unix timestamp when the track started playing.
|
|
Timestamp int64 `json:"timestamp"`
|
|
}
|
|
|
|
// PlaybackReportRequest is the request for playback report notifications.
|
|
type PlaybackReportRequest struct {
|
|
// Username is the username of the user.
|
|
Username string `json:"username"`
|
|
// Track is the track being played.
|
|
Track TrackInfo `json:"track"`
|
|
// State is the current playback state (starting/playing/paused/stopped/expired).
|
|
State string `json:"state"`
|
|
// PositionMs is the current playback position in milliseconds.
|
|
PositionMs int64 `json:"positionMs"`
|
|
// PlaybackRate is the playback speed (1.0 = normal).
|
|
PlaybackRate float64 `json:"playbackRate"`
|
|
// PlayerId is the unique client identifier.
|
|
PlayerId string `json:"playerId"`
|
|
// PlayerName is the human-readable player name.
|
|
PlayerName string `json:"playerName"`
|
|
// Timestamp is the Unix timestamp when this report was generated.
|
|
Timestamp int64 `json:"timestamp"`
|
|
}
|
|
|
|
// ScrobblerError represents an error type for scrobbling operations.
|
|
type ScrobblerError string
|
|
|
|
const (
|
|
// ScrobblerErrorNotAuthorized indicates the user is not authorized.
|
|
ScrobblerErrorNotAuthorized ScrobblerError = "scrobbler(not_authorized)"
|
|
// ScrobblerErrorRetryLater indicates the operation should be retried later.
|
|
ScrobblerErrorRetryLater ScrobblerError = "scrobbler(retry_later)"
|
|
// ScrobblerErrorUnrecoverable indicates an unrecoverable error.
|
|
ScrobblerErrorUnrecoverable ScrobblerError = "scrobbler(unrecoverable)"
|
|
)
|
|
|
|
// Error implements the error interface for ScrobblerError.
|
|
func (e ScrobblerError) Error() string { return string(e) }
|