mirror of
https://github.com/navidrome/navidrome.git
synced 2026-03-04 06:35:52 +00:00
* fix(plugins): add base64 handling for []byte and remove raw=true Go's json.Marshal automatically base64-encodes []byte fields, but Rust's serde_json serializes Vec<u8> as a JSON array and Python's json.dumps raises TypeError on bytes. This fixes both directions of plugin communication by adding proper base64 encoding/decoding in generated client code. For Rust templates (client and capability): adds a base64_bytes serde helper module with #[serde(with = "base64_bytes")] on all Vec<u8> fields, and adds base64 as a dependency. For Python templates: wraps bytes params with base64.b64encode() and responses with base64.b64decode(). Also removes the raw=true binary framing protocol from all templates, the parser, and the Method type. The raw mechanism added complexity that is no longer needed once []byte works properly over JSON. * fix(plugins): update production code and tests for base64 migration Remove raw=true annotation from SubsonicAPI.CallRaw, delete all raw test fixtures, remove raw-related test cases from parser, generator, and integration tests, and add new test cases validating base64 handling for Rust and Python templates. * fix(plugins): update golden files and regenerate production code Update golden test fixtures for codec and comprehensive services to include base64 handling for []byte fields. Regenerate all production PDK code (Go, Rust, Python) and host wrappers to use standard JSON with base64-encoded byte fields instead of binary framing protocol. * refactor: remove base64 helper duplication from rust template Signed-off-by: Deluan <deluan@navidrome.org> * fix(plugins): add base64 dependency to capabilities' Cargo.toml Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org>
137 lines
3.8 KiB
Go
137 lines
3.8 KiB
Go
// Code generated by ndpgen. DO NOT EDIT.
|
|
|
|
package host
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
|
|
extism "github.com/extism/go-sdk"
|
|
)
|
|
|
|
// SubsonicAPICallRequest is the request type for SubsonicAPI.Call.
|
|
type SubsonicAPICallRequest struct {
|
|
Uri string `json:"uri"`
|
|
}
|
|
|
|
// SubsonicAPICallResponse is the response type for SubsonicAPI.Call.
|
|
type SubsonicAPICallResponse struct {
|
|
ResponseJSON string `json:"responseJson,omitempty"`
|
|
Error string `json:"error,omitempty"`
|
|
}
|
|
|
|
// SubsonicAPICallRawRequest is the request type for SubsonicAPI.CallRaw.
|
|
type SubsonicAPICallRawRequest struct {
|
|
Uri string `json:"uri"`
|
|
}
|
|
|
|
// SubsonicAPICallRawResponse is the response type for SubsonicAPI.CallRaw.
|
|
type SubsonicAPICallRawResponse struct {
|
|
ContentType string `json:"contentType,omitempty"`
|
|
Data []byte `json:"data,omitempty"`
|
|
Error string `json:"error,omitempty"`
|
|
}
|
|
|
|
// RegisterSubsonicAPIHostFunctions registers SubsonicAPI service host functions.
|
|
// The returned host functions should be added to the plugin's configuration.
|
|
func RegisterSubsonicAPIHostFunctions(service SubsonicAPIService) []extism.HostFunction {
|
|
return []extism.HostFunction{
|
|
newSubsonicAPICallHostFunction(service),
|
|
newSubsonicAPICallRawHostFunction(service),
|
|
}
|
|
}
|
|
|
|
func newSubsonicAPICallHostFunction(service SubsonicAPIService) extism.HostFunction {
|
|
return extism.NewHostFunctionWithStack(
|
|
"subsonicapi_call",
|
|
func(ctx context.Context, p *extism.CurrentPlugin, stack []uint64) {
|
|
// Read JSON request from plugin memory
|
|
reqBytes, err := p.ReadBytes(stack[0])
|
|
if err != nil {
|
|
subsonicapiWriteError(p, stack, err)
|
|
return
|
|
}
|
|
var req SubsonicAPICallRequest
|
|
if err := json.Unmarshal(reqBytes, &req); err != nil {
|
|
subsonicapiWriteError(p, stack, err)
|
|
return
|
|
}
|
|
|
|
// Call the service method
|
|
responsejson, svcErr := service.Call(ctx, req.Uri)
|
|
if svcErr != nil {
|
|
subsonicapiWriteError(p, stack, svcErr)
|
|
return
|
|
}
|
|
|
|
// Write JSON response to plugin memory
|
|
resp := SubsonicAPICallResponse{
|
|
ResponseJSON: responsejson,
|
|
}
|
|
subsonicapiWriteResponse(p, stack, resp)
|
|
},
|
|
[]extism.ValueType{extism.ValueTypePTR},
|
|
[]extism.ValueType{extism.ValueTypePTR},
|
|
)
|
|
}
|
|
|
|
func newSubsonicAPICallRawHostFunction(service SubsonicAPIService) extism.HostFunction {
|
|
return extism.NewHostFunctionWithStack(
|
|
"subsonicapi_callraw",
|
|
func(ctx context.Context, p *extism.CurrentPlugin, stack []uint64) {
|
|
// Read JSON request from plugin memory
|
|
reqBytes, err := p.ReadBytes(stack[0])
|
|
if err != nil {
|
|
subsonicapiWriteError(p, stack, err)
|
|
return
|
|
}
|
|
var req SubsonicAPICallRawRequest
|
|
if err := json.Unmarshal(reqBytes, &req); err != nil {
|
|
subsonicapiWriteError(p, stack, err)
|
|
return
|
|
}
|
|
|
|
// Call the service method
|
|
contenttype, data, svcErr := service.CallRaw(ctx, req.Uri)
|
|
if svcErr != nil {
|
|
subsonicapiWriteError(p, stack, svcErr)
|
|
return
|
|
}
|
|
|
|
// Write JSON response to plugin memory
|
|
resp := SubsonicAPICallRawResponse{
|
|
ContentType: contenttype,
|
|
Data: data,
|
|
}
|
|
subsonicapiWriteResponse(p, stack, resp)
|
|
},
|
|
[]extism.ValueType{extism.ValueTypePTR},
|
|
[]extism.ValueType{extism.ValueTypePTR},
|
|
)
|
|
}
|
|
|
|
// subsonicapiWriteResponse writes a JSON response to plugin memory.
|
|
func subsonicapiWriteResponse(p *extism.CurrentPlugin, stack []uint64, resp any) {
|
|
respBytes, err := json.Marshal(resp)
|
|
if err != nil {
|
|
subsonicapiWriteError(p, stack, err)
|
|
return
|
|
}
|
|
respPtr, err := p.WriteBytes(respBytes)
|
|
if err != nil {
|
|
stack[0] = 0
|
|
return
|
|
}
|
|
stack[0] = respPtr
|
|
}
|
|
|
|
// subsonicapiWriteError writes an error response to plugin memory.
|
|
func subsonicapiWriteError(p *extism.CurrentPlugin, stack []uint64, err error) {
|
|
errResp := struct {
|
|
Error string `json:"error"`
|
|
}{Error: err.Error()}
|
|
respBytes, _ := json.Marshal(errResp)
|
|
respPtr, _ := p.WriteBytes(respBytes)
|
|
stack[0] = respPtr
|
|
}
|