mirror of
https://github.com/navidrome/navidrome.git
synced 2026-03-04 06:35:52 +00:00
* feat(plugins): define TaskQueue host service interface Add the TaskQueueService interface with CreateQueue, Enqueue, GetTaskStatus, and CancelTask methods plus QueueConfig struct. * feat(plugins): define TaskWorker capability for task execution callbacks * feat(plugins): add taskqueue permission to manifest schema Add TaskQueuePermission with maxConcurrency option. * feat(plugins): implement TaskQueue service with SQLite persistence and workers Per-plugin SQLite database with queues and tasks tables. Worker goroutines dequeue tasks and invoke nd_task_execute callback. Exponential backoff retries, rate limiting via delayMs, automatic cleanup of terminal tasks. * feat(plugins): require TaskWorker capability for taskqueue permission * feat(plugins): register TaskQueue host service in manager * feat(plugins): add test-taskqueue plugin for integration testing * feat(plugins): add integration tests for TaskQueue host service * docs: document TaskQueue module for persistent task queues Signed-off-by: Deluan <deluan@navidrome.org> * fix(plugins): harden TaskQueue host service with validation and safety improvements Add input validation (queue name length, payload size limits), extract status string constants to eliminate raw SQL literals, make CreateQueue idempotent via upsert for crash recovery, fix RetentionMs default check for negative values, cap exponential backoff at 1 hour to prevent overflow, and replace manual mutex-based delay enforcement with rate.Limiter from golang.org/x/time/rate for correct concurrent worker serialization. * refactor(plugins): remove capability check for TaskWorker in TaskQueue host service Signed-off-by: Deluan <deluan@navidrome.org> * fix(plugins): use context-aware database execution in TaskQueue host service Signed-off-by: Deluan <deluan@navidrome.org> * refactor(plugins): streamline task queue configuration and error handling Signed-off-by: Deluan <deluan@navidrome.org> * feat(plugins): increase maxConcurrency for task queue and handle budget exhaustion Signed-off-by: Deluan <deluan@navidrome.org> * refactor(plugins): simplify goroutine management in task queue service Signed-off-by: Deluan <deluan@navidrome.org> * feat(plugins): update TaskWorker interface to return status messages and refactor task queue service Signed-off-by: Deluan <deluan@navidrome.org> * feat(plugins): add ClearQueue function to remove pending tasks from a specified queue Signed-off-by: Deluan <deluan@navidrome.org> * refactor(plugins): use migrateDB for task queue schema and fix constant name collision Replaced the raw db.Exec call in createTaskQueueSchema with migrateDB, matching the pattern used by createKVStoreSchema. This enables version-tracked schema migrations via SQLite's PRAGMA user_version, allowing future schema changes to be appended incrementally. Also renamed cleanupInterval to taskCleanupInterval to resolve a redeclaration conflict with host_kvstore.go. * regenerate PDKs Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org>
74 lines
2.8 KiB
Go
74 lines
2.8 KiB
Go
package host
|
|
|
|
import "context"
|
|
|
|
// TaskInfo holds the current state of a task.
|
|
type TaskInfo struct {
|
|
// Status is the current task status: "pending", "running",
|
|
// "completed", "failed", or "cancelled".
|
|
Status string `json:"status"`
|
|
// Message is the status/result message returned by the plugin callback.
|
|
Message string `json:"message"`
|
|
// Attempt is the current or last attempt number (1-based).
|
|
Attempt int32 `json:"attempt"`
|
|
}
|
|
|
|
// QueueConfig holds configuration for a task queue.
|
|
type QueueConfig struct {
|
|
// Concurrency is the max number of parallel workers. Default: 1.
|
|
// Capped by the plugin's manifest maxConcurrency.
|
|
Concurrency int32 `json:"concurrency"`
|
|
|
|
// MaxRetries is the number of times to retry a failed task. Default: 0.
|
|
MaxRetries int32 `json:"maxRetries"`
|
|
|
|
// BackoffMs is the initial backoff between retries in milliseconds.
|
|
// Doubles each retry (exponential: backoffMs * 2^(attempt-1)). Default: 1000.
|
|
BackoffMs int64 `json:"backoffMs"`
|
|
|
|
// DelayMs is the minimum delay between starting consecutive tasks
|
|
// in milliseconds. Useful for rate limiting. Default: 0.
|
|
DelayMs int64 `json:"delayMs"`
|
|
|
|
// RetentionMs is how long completed/failed/cancelled tasks are kept
|
|
// in milliseconds. Default: 3600000 (1h). Min: 60000 (1m). Max: 604800000 (1w).
|
|
RetentionMs int64 `json:"retentionMs"`
|
|
}
|
|
|
|
// TaskService provides persistent task queues for plugins.
|
|
//
|
|
// This service allows plugins to create named queues with configurable concurrency,
|
|
// retry policies, and rate limiting. Tasks are persisted to SQLite and survive
|
|
// server restarts. When a task is ready to execute, the host calls the plugin's
|
|
// nd_task_execute callback function.
|
|
//
|
|
//nd:hostservice name=Task permission=taskqueue
|
|
type TaskService interface {
|
|
// CreateQueue creates a named task queue with the given configuration.
|
|
// Zero-value fields in config use sensible defaults.
|
|
// If a queue with the same name already exists, returns an error.
|
|
// On startup, this also recovers any stale "running" tasks from a previous crash.
|
|
//nd:hostfunc
|
|
CreateQueue(ctx context.Context, name string, config QueueConfig) error
|
|
|
|
// Enqueue adds a task to the named queue. Returns the task ID.
|
|
// payload is opaque bytes passed back to the plugin on execution.
|
|
//nd:hostfunc
|
|
Enqueue(ctx context.Context, queueName string, payload []byte) (string, error)
|
|
|
|
// Get returns the current state of a task including its status,
|
|
// message, and attempt count.
|
|
//nd:hostfunc
|
|
Get(ctx context.Context, taskID string) (*TaskInfo, error)
|
|
|
|
// Cancel cancels a pending task. Returns error if already
|
|
// running, completed, or failed.
|
|
//nd:hostfunc
|
|
Cancel(ctx context.Context, taskID string) error
|
|
|
|
// ClearQueue removes all pending tasks from the named queue.
|
|
// Running tasks are not affected. Returns the number of tasks removed.
|
|
//nd:hostfunc
|
|
ClearQueue(ctx context.Context, queueName string) (int64, error)
|
|
}
|