mirror of
https://github.com/navidrome/navidrome.git
synced 2026-03-04 06:35:52 +00:00
82f9f88c0f
Introduced a typed Claims struct in core/auth to replace the raw map[string]any approach used for JWT claims throughout the codebase. This provides compile-time safety and better readability when creating, validating, and extracting JWT tokens. Also upgraded lestrrat-go/jwx from v2 to v3 and go-chi/jwtauth to v5.4.0, adapting all callers to the new API where token accessor methods now return tuples instead of bare values. Updated all affected handlers, middleware, and tests. Signed-off-by: Deluan <deluan@navidrome.org>
111 lines
2.8 KiB
Go
111 lines
2.8 KiB
Go
package auth_test
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/navidrome/navidrome/conf"
|
|
"github.com/navidrome/navidrome/consts"
|
|
"github.com/navidrome/navidrome/core/auth"
|
|
"github.com/navidrome/navidrome/log"
|
|
"github.com/navidrome/navidrome/model"
|
|
"github.com/navidrome/navidrome/tests"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
func TestAuth(t *testing.T) {
|
|
log.SetLevel(log.LevelFatal)
|
|
RegisterFailHandler(Fail)
|
|
RunSpecs(t, "Auth Test Suite")
|
|
}
|
|
|
|
const (
|
|
testJWTSecret = "not so secret"
|
|
oneDay = 24 * time.Hour
|
|
)
|
|
|
|
var _ = BeforeSuite(func() {
|
|
conf.Server.SessionTimeout = 2 * oneDay
|
|
})
|
|
|
|
var _ = Describe("Auth", func() {
|
|
|
|
BeforeEach(func() {
|
|
ds := &tests.MockDataStore{
|
|
MockedProperty: &tests.MockedPropertyRepo{},
|
|
}
|
|
auth.Init(ds)
|
|
})
|
|
|
|
Describe("Validate", func() {
|
|
It("returns error with an invalid JWT token", func() {
|
|
_, err := auth.Validate("invalid.token")
|
|
Expect(err).To(HaveOccurred())
|
|
})
|
|
|
|
It("returns the claims from a valid JWT token", func() {
|
|
claims := map[string]any{}
|
|
claims["iss"] = "issuer"
|
|
claims["iat"] = time.Now().Unix()
|
|
claims["exp"] = time.Now().Add(1 * time.Minute).Unix()
|
|
_, tokenStr, err := auth.TokenAuth.Encode(claims)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
decodedClaims, err := auth.Validate(tokenStr)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(decodedClaims.Issuer).To(Equal("issuer"))
|
|
})
|
|
|
|
It("returns ErrExpired if the `exp` field is in the past", func() {
|
|
claims := map[string]any{}
|
|
claims["iss"] = "issuer"
|
|
claims["exp"] = time.Now().Add(-1 * time.Minute).Unix()
|
|
_, tokenStr, err := auth.TokenAuth.Encode(claims)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
_, err = auth.Validate(tokenStr)
|
|
Expect(err).To(MatchError("token is expired"))
|
|
})
|
|
})
|
|
|
|
Describe("CreateToken", func() {
|
|
It("creates a valid token", func() {
|
|
u := &model.User{
|
|
ID: "123",
|
|
UserName: "johndoe",
|
|
IsAdmin: true,
|
|
}
|
|
tokenStr, err := auth.CreateToken(u)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
claims, err := auth.Validate(tokenStr)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
Expect(claims.Issuer).To(Equal(consts.JWTIssuer))
|
|
Expect(claims.Subject).To(Equal("johndoe"))
|
|
Expect(claims.UserID).To(Equal("123"))
|
|
Expect(claims.IsAdmin).To(Equal(true))
|
|
Expect(claims.ExpiresAt).To(BeTemporally(">", time.Now()))
|
|
})
|
|
})
|
|
|
|
Describe("TouchToken", func() {
|
|
It("updates the expiration time", func() {
|
|
yesterday := time.Now().Add(-oneDay)
|
|
claims := map[string]any{}
|
|
claims["iss"] = "issuer"
|
|
claims["exp"] = yesterday.Unix()
|
|
token, _, err := auth.TokenAuth.Encode(claims)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
touched, err := auth.TouchToken(token)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
|
|
decodedClaims, err := auth.Validate(touched)
|
|
Expect(err).NotTo(HaveOccurred())
|
|
Expect(decodedClaims.ExpiresAt.Sub(yesterday)).To(BeNumerically(">=", oneDay))
|
|
})
|
|
})
|
|
})
|