Mark name and members as optional fields in CreateGroupRequest

This commit is contained in:
Era Dorta 2026-04-08 19:26:42 +02:00
parent 2a776618e9
commit 59d6912f21
5 changed files with 14 additions and 17 deletions

View File

@ -39,8 +39,8 @@ type UpdateContactRequest struct {
} }
type CreateGroupRequest struct { type CreateGroupRequest struct {
Name string `json:"name"` Name string `json:"name,omitempty"`
Members []string `json:"members"` Members []string `json:"members,omitempty"`
Description string `json:"description,omitempty"` Description string `json:"description,omitempty"`
Permissions ds.GroupPermissions `json:"permissions,omitempty"` Permissions ds.GroupPermissions `json:"permissions,omitempty"`
GroupLinkState string `json:"group_link,omitempty" enums:"disabled,enabled,enabled-with-approval"` GroupLinkState string `json:"group_link,omitempty" enums:"disabled,enabled,enabled-with-approval"`

View File

@ -1080,8 +1080,8 @@ func (s *SignalClient) CreateGroup(number string, name string, members []string,
var internalGroupId string var internalGroupId string
if s.signalCliMode == JsonRpc { if s.signalCliMode == JsonRpc {
type Request struct { type Request struct {
Name string `json:"name"` Name string `json:"name,omitempty"`
Members []string `json:"members"` Members []string `json:"members,omitempty"`
Link string `json:"link,omitempty"` Link string `json:"link,omitempty"`
Description string `json:"description,omitempty"` Description string `json:"description,omitempty"`
EditGroupPermissions string `json:"setPermissionEditDetails,omitempty"` EditGroupPermissions string `json:"setPermissionEditDetails,omitempty"`
@ -1135,8 +1135,16 @@ func (s *SignalClient) CreateGroup(number string, name string, members []string,
} }
internalGroupId = resp.GroupId internalGroupId = resp.GroupId
} else { } else {
cmd := []string{"--config", s.signalCliConfig, "-a", number, "updateGroup", "-n", name, "-m"} cmd := []string{"--config", s.signalCliConfig, "-a", number, "updateGroup"}
if name != "" {
cmd = append(cmd, []string{"--n", name}...)
}
if len(members) > 0 {
cmd = append(cmd, "-m")
cmd = append(cmd, prefixUsernameMembers(members)...) cmd = append(cmd, prefixUsernameMembers(members)...)
}
if addMembersPermission != DefaultGroupPermission { if addMembersPermission != DefaultGroupPermission {
cmd = append(cmd, []string{"--set-permission-add-member", addMembersPermission.String()}...) cmd = append(cmd, []string{"--set-permission-add-member", addMembersPermission.String()}...)

View File

@ -2790,10 +2790,6 @@ const docTemplate = `{
}, },
"api.CreateGroupRequest": { "api.CreateGroupRequest": {
"type": "object", "type": "object",
"required": [
"members",
"name"
],
"properties": { "properties": {
"description": { "description": {
"type": "string" "type": "string"

View File

@ -2787,10 +2787,6 @@
}, },
"api.CreateGroupRequest": { "api.CreateGroupRequest": {
"type": "object", "type": "object",
"required": [
"members",
"name"
],
"properties": { "properties": {
"description": { "description": {
"type": "string" "type": "string"

View File

@ -76,9 +76,6 @@ definitions:
type: string type: string
permissions: permissions:
$ref: '#/definitions/data.GroupPermissions' $ref: '#/definitions/data.GroupPermissions'
required:
- members
- name
type: object type: object
api.CreateGroupResponse: api.CreateGroupResponse:
properties: properties: