Merge a6b4392fd7549f23fef1faaaa146c5408011d7c5 into 5d5fa64f01601538f6c410695f633302ea5c933f

code cleanup: removed unused variable
fixed error handling in updateGroupMembers function
2026-09-22 06:29:09 +00:00 · 2026-02-17 22:11:45 +01:00 · 2026-02-17 22:04:07 +01:00 · 2026-02-17 22:02:31 +01:00
1 changed files with 2 additions and 2 deletions
--- a/src/client/client.go
+++ b/src/client/client.go
@ -1168,7 +1168,6 @@ func prefixUsernameMembers(members []string) []string {
 }

 func (s *SignalClient) updateGroupMembers(number string, groupId string, members []string, add bool) error {
-	var err error

 	if len(members) == 0 {
 		return nil
@ -1207,6 +1206,7 @@ func (s *SignalClient) updateGroupMembers(number string, groupId string, members
 			return err
 		}
 		_, err = jsonRpc2Client.getRaw("updateGroup", &number, request)
+		return err
 	} else {
 		cmd := []string{"--config", s.signalCliConfig, "-a", number, "updateGroup", "-g", internalGroupId}

@ -1218,8 +1218,8 @@ func (s *SignalClient) updateGroupMembers(number string, groupId string, members
 		cmd = append(cmd, members...)

 		_, err = s.cliClient.Execute(true, cmd, "")
+		return err
 	}
-	return err
 }

 func (s *SignalClient) AddMembersToGroup(number string, groupId string, members []string) error {
Author	SHA1	Message	Date
Alexander	86b7f3fc8f	Merge a6b4392fd7549f23fef1faaaa146c5408011d7c5 into 5d5fa64f01601538f6c410695f633302ea5c933f	2026-02-17 22:11:45 +01:00
Bernhard B	5d5fa64f01	code cleanup: removed unused variable	2026-02-17 22:04:07 +01:00
Bernhard B	6c5dcdad2e	fixed error handling in updateGroupMembers function see #790	2026-02-17 22:02:31 +01:00