Merge e98c03e702efaed305be0d1a5379ea1b3a8d2f2f into 2838e1f879ff3641a3ef1f25a6466417756bbfd8

Merge pull request #828 from Gara-Dorta/additional-api-checks
refactor: add missing checks on required fields
2026-05-26 14:44:15 +00:00 · 2026-04-09 22:25:32 +02:00 · 2026-04-09 22:18:55 +02:00 · 2026-04-08 19:10:48 +02:00
1 changed files with 25 additions and 0 deletions
--- a/src/api/api.go
+++ b/src/api/api.go
@ -873,6 +873,11 @@ func (a *Api) AddMembersToGroup(c *gin.Context) {
 		return
 	}

+	if len(req.Members) == 0 {
+		c.JSON(400, Error{Msg: "Couldn't process request - group members missing"})
+		return
+	}
+
 	err = a.signalClient.AddMembersToGroup(number, groupId, req.Members)
 	if err != nil {
 		switch err.(type) {
@ -1279,6 +1284,16 @@ func (a *Api) UnpinMessageInGroup(c *gin.Context) {
 		return
 	}

+	if req.TargetAuthor == "" {
+		c.JSON(400, Error{Msg: "Couldn't process request - target author missing"})
+		return
+	}
+
+	if req.Timestamp == 0 {
+		c.JSON(400, Error{Msg: "Couldn't process request - timestamp missing"})
+		return
+	}
+
 	err = a.signalClient.UnpinMessageInGroup(number, groupId, req.TargetAuthor, req.Timestamp)
 	if err != nil {
 		c.JSON(400, Error{Msg: err.Error()})
@ -2385,6 +2400,16 @@ func (a *Api) SubmitRateLimitChallenge(c *gin.Context) {
 		return
 	}

+	if req.ChallengeToken == "" {
+		c.JSON(400, Error{Msg: "Couldn't process request - challenge token missing"})
+		return
+	}
+
+	if req.Captcha == "" {
+		c.JSON(400, Error{Msg: "Couldn't process request - captcha missing"})
+		return
+	}
+
 	err = a.signalClient.SubmitRateLimitChallenge(number, req.ChallengeToken, req.Captcha)
 	if err != nil {
 		c.JSON(400, Error{Msg: err.Error()})
Author	SHA1	Message	Date
Stephan Richter	11e7af5131	Merge e98c03e702efaed305be0d1a5379ea1b3a8d2f2f into 2838e1f879ff3641a3ef1f25a6466417756bbfd8	2026-04-09 22:25:32 +02:00
Bernhard B.	2838e1f879	Merge pull request #828 from Gara-Dorta/additional-api-checks refactor: add missing checks on required fields	2026-04-09 22:18:55 +02:00
Era Dorta	5a883826ae	refactor: add missing checks on required fields	2026-04-08 19:10:48 +02:00