Merge a6b4392fd7549f23fef1faaaa146c5408011d7c5 into 1129e5a7bec43c90dc0631b8090a7ea590bcf082

fixed error handling in updateGroupAdmins function
see #790
2026-09-21 06:20:08 +00:00 · 2026-02-23 11:11:48 +11:00 · 2026-02-22 22:11:46 +01:00 · 2026-02-17 23:51:02 +01:00 · 2026-02-17 23:49:55 +01:00
2 changed files with 5 additions and 5 deletions
--- a/5
+++ b/5
@ -1,9 +1,10 @@
 ARG SIGNAL_CLI_VERSION=0.13.24
 ARG LIBSIGNAL_CLIENT_VERSION=0.87.0
-ARG SIGNAL_CLI_NATIVE_PACKAGE_VERSION=0.13.24+morph027+1
+ARG SIGNAL_CLI_NATIVE_PACKAGE_VERSION=0.13.24+morph027+2

 ARG SWAG_VERSION=1.16.4
-ARG GRAALVM_VERSION=25.0.2
+ARG GRAALVM_VERSION=21.0.0
+#ARG GRAALVM_VERSION=25.0.2

 ARG BUILD_VERSION_ARG=unset

--- a/src/client/client.go
+++ b/src/client/client.go
@ -1231,8 +1231,6 @@ func (s *SignalClient) RemoveMembersFromGroup(number string, groupId string, mem
 }

 func (s *SignalClient) updateGroupAdmins(number string, groupId string, admins []string, add bool) error {
-	var err error
-
 	if len(admins) == 0 {
 		return nil
 	}
@ -1270,6 +1268,7 @@ func (s *SignalClient) updateGroupAdmins(number string, groupId string, admins [
 			return err
 		}
 		_, err = jsonRpc2Client.getRaw("updateGroup", &number, request)
+		return err
 	} else {
 		cmd := []string{"--config", s.signalCliConfig, "-a", number, "updateGroup", "-g", internalGroupId}

@ -1281,8 +1280,8 @@ func (s *SignalClient) updateGroupAdmins(number string, groupId string, admins [
 		cmd = append(cmd, admins...)

 		_, err = s.cliClient.Execute(true, cmd, "")
+		return err
 	}
-	return err
 }

 func (s *SignalClient) AddAdminsToGroup(number string, groupId string, admins []string) error {
Author	SHA1	Message	Date
Alexander	a60c416291	Merge a6b4392fd7549f23fef1faaaa146c5408011d7c5 into 1129e5a7bec43c90dc0631b8090a7ea590bcf082	2026-02-23 11:11:48 +11:00
Bernhard B	1129e5a7be	fixed error handling in updateGroupAdmins function see #790	2026-02-22 22:11:46 +01:00
Bernhard B	8533043ba2	updated signal-cli-native package	2026-02-17 23:51:02 +01:00
Bernhard B	9a24992b94	switch back to GraalVM v21.0.0 * accidentally switched to early to GraalVM 25.0.0 - signal-cli v0.13.24 requires still GraalVM v21.0.0.	2026-02-17 23:49:55 +01:00