nik/signal-cli
1
0
Fork 0
mirror of https://github.com/AsamK/signal-cli.git synced 2026-09-01 06:28:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename --no-push flag to --no-urgent

Browse Source 
Align with the protocol naming as suggested by the maintainer.
The flag controls the 'urgent' parameter on the server request.
This commit is contained in:
Kai Kozlov 2026-02-25 12:04:29 -06:00
parent 0c99086093
commit 3736e93694
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/src/main/java/org/asamk/signal/manager/api/Message.java
View File

@ -13,7 +13,7 @@ public record Message(
List<Preview> previews,
Optional<StoryReply> storyReply,
List<TextStyle> textStyles,
boolean noPush
boolean noUrgent
) {
public record Mention(RecipientIdentifier.Single recipient, int start, int length) {}

4
lib/src/main/java/org/asamk/signal/manager/internal/ManagerImpl.java
View File

@ -800,7 +800,7 @@ public class ManagerImpl implements Manager {
}
final var messageBuilder = SignalServiceDataMessage.newBuilder();
applyMessage(messageBuilder, message);
return sendMessage(messageBuilder, recipients, notifySelf, Optional.empty(), !message.noPush());
return sendMessage(messageBuilder, recipients, notifySelf, Optional.empty(), !message.noUrgent());
}
@Override
@ -811,7 +811,7 @@ public class ManagerImpl implements Manager {
) throws IOException, AttachmentInvalidException, NotAGroupMemberException, GroupNotFoundException, GroupSendingNotAllowedException, UnregisteredRecipientException, InvalidStickerException {
final var messageBuilder = SignalServiceDataMessage.newBuilder();
applyMessage(messageBuilder, message);
return sendMessage(messageBuilder, recipients, false, Optional.of(editTargetTimestamp), !message.noPush());
return sendMessage(messageBuilder, recipients, false, Optional.of(editTargetTimestamp), !message.noUrgent());
}
private void applyMessage(

8
src/main/java/org/asamk/signal/commands/SendCommand.java
View File

@ -105,9 +105,9 @@ public class SendCommand implements JsonRpcLocalCommand {
subparser.addArgument("--edit-timestamp")
.type(long.class)
.help("Specify the timestamp of a previous message with the recipient or group to send an edited message.");
subparser.addArgument("--no-push")
subparser.addArgument("--no-urgent")
.action(Arguments.storeTrue())
.help("Send the message without triggering a push notification for the recipient. "
.help("Send the message without the urgent flag, so no push notification is triggered for the recipient. "
+ "The message will still be delivered in real-time if the recipient's app is active.");
}
@ -119,7 +119,7 @@ public class SendCommand implements JsonRpcLocalCommand {
) throws CommandException {
final var notifySelf = Boolean.TRUE.equals(ns.getBoolean("notify-self"));
final var isNoteToSelf = Boolean.TRUE.equals(ns.getBoolean("note-to-self"));
final var noPush = Boolean.TRUE.equals(ns.getBoolean("no-push"));
final var noUrgent = Boolean.TRUE.equals(ns.getBoolean("no-urgent"));
final var recipientStrings = ns.<String>getList("recipient");
final var groupIdStrings = ns.<String>getList("group-id");
final var usernameStrings = ns.<String>getList("username");
@ -253,7 +253,7 @@ public class SendCommand implements JsonRpcLocalCommand {
previews,
Optional.ofNullable((storyReply)),
textStyles,
noPush);
noUrgent);
var results = editTimestamp != null
? m.sendEditMessage(message, recipientIdentifiers, editTimestamp)
: m.sendMessage(message, recipientIdentifiers, notifySelf);