From 82abc208710f35be759907970b31c42646d48d5d Mon Sep 17 00:00:00 2001 From: AsamK Date: Sat, 24 Jan 2026 15:35:48 +0100 Subject: [PATCH] Remove deprecated functionality --- CHANGELOG.md | 6 ++++++ src/main/java/org/asamk/Signal.java | 3 --- src/main/java/org/asamk/signal/ServiceEnvironmentCli.java | 6 ------ src/main/java/org/asamk/signal/commands/DaemonCommand.java | 5 ++--- src/main/java/org/asamk/signal/dbus/DbusSignalImpl.java | 6 ------ 5 files changed, 8 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b394da23..880b4a98 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,12 @@ ## [Unreleased] +### Breaking changes + +- Remove isRegistered method without parameters from Signal dbus interface, which always returned `true` +- Remove `sandbox` value for --service-environment parameter, use `staging` instead +- The `daemon` command now requires at least one channel parameter (`--socket`, `--dbus`, ...) and no longer defaults to dbus + ## [0.13.23] - 2026-01-24 Requires libsignal-client version 0.86.12. diff --git a/src/main/java/org/asamk/Signal.java b/src/main/java/org/asamk/Signal.java index ac1f6d50..6e1972d6 100644 --- a/src/main/java/org/asamk/Signal.java +++ b/src/main/java/org/asamk/Signal.java @@ -143,9 +143,6 @@ public interface Signal extends DBusInterface { String avatar ) throws Error.AttachmentInvalid, Error.Failure, Error.InvalidNumber, Error.GroupNotFound, Error.InvalidGroupId; - @Deprecated - boolean isRegistered() throws Error.Failure, Error.InvalidNumber; - boolean isRegistered(String number) throws Error.Failure, Error.InvalidNumber; List isRegistered(List numbers) throws Error.Failure, Error.InvalidNumber; diff --git a/src/main/java/org/asamk/signal/ServiceEnvironmentCli.java b/src/main/java/org/asamk/signal/ServiceEnvironmentCli.java index 62480678..9010f3f8 100644 --- a/src/main/java/org/asamk/signal/ServiceEnvironmentCli.java +++ b/src/main/java/org/asamk/signal/ServiceEnvironmentCli.java @@ -13,10 +13,4 @@ public enum ServiceEnvironmentCli { return "staging"; } }, - @Deprecated SANDBOX { - @Override - public String toString() { - return "sandbox"; - } - }, } diff --git a/src/main/java/org/asamk/signal/commands/DaemonCommand.java b/src/main/java/org/asamk/signal/commands/DaemonCommand.java index 6790c65d..fae370a5 100644 --- a/src/main/java/org/asamk/signal/commands/DaemonCommand.java +++ b/src/main/java/org/asamk/signal/commands/DaemonCommand.java @@ -10,6 +10,7 @@ import org.asamk.signal.ReceiveMessageHandler; import org.asamk.signal.Shutdown; import org.asamk.signal.commands.exceptions.CommandException; import org.asamk.signal.commands.exceptions.IOErrorException; +import org.asamk.signal.commands.exceptions.UserErrorException; import org.asamk.signal.dbus.DbusHandler; import org.asamk.signal.http.HttpServerHandler; import org.asamk.signal.json.JsonReceiveMessageHandler; @@ -201,9 +202,7 @@ public class DaemonCommand implements MultiLocalCommand, LocalCommand { && tcpAddress == null && httpAddress == null && inheritedChannel == null) { - logger.warn( - "Running daemon command without explicit mode is deprecated. Use 'daemon --dbus' to use the dbus interface."); - daemonHandler.runDbus(false, DbusConfig.getBusname()); + throw new UserErrorException("At least one channel parameter is required, e.g. --socket or --dbus."); } } diff --git a/src/main/java/org/asamk/signal/dbus/DbusSignalImpl.java b/src/main/java/org/asamk/signal/dbus/DbusSignalImpl.java index 2c0a1101..98720728 100644 --- a/src/main/java/org/asamk/signal/dbus/DbusSignalImpl.java +++ b/src/main/java/org/asamk/signal/dbus/DbusSignalImpl.java @@ -675,12 +675,6 @@ public class DbusSignalImpl implements Signal, AutoCloseable { } } - @Override - @Deprecated - public boolean isRegistered() { - return true; - } - @Override public boolean isRegistered(String number) { var result = isRegistered(List.of(number));