nik/signal-cli
1
0
Fork 0
mirror of https://github.com/AsamK/signal-cli.git synced 2026-05-12 12:20:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Guard handleIncoming* methods against missing call event listeners

Browse Source 
Skip processing incoming call offers when no call event listeners are
registered, since there is nobody to notify about the call. For hangup
and busy, also guard when there are no listeners AND no active call
(the tunnel may still need cleanup if already spawned).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Shaheen Gandhi 2026-03-17 16:27:24 -07:00
parent cb7725482a
commit a481584c3a
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
lib/src/main/java/org/asamk/signal/manager/helper/CallManager.java
View File

@ -204,6 +204,20 @@ public class CallManager implements AutoCloseable {
final MessageEnvelope.Call.Offer.Type type,
final byte[] opaque
) {
if (callEventListeners.isEmpty()) {
logger.debug("Ignoring incoming offer for call {}: no call event listeners registered", callId);
try {
var address = context.getRecipientHelper().resolveSignalServiceAddress(senderId);
var busyMessage = new org.whispersystems.signalservice.api.messages.calls.BusyMessage(callId);
var callMessage = org.whispersystems.signalservice.api.messages.calls.SignalServiceCallMessage.forBusy(
busyMessage, null);
dependencies.getMessageSender().sendCallMessage(address, null, callMessage);
} catch (Exception e) {
logger.warn("Failed to send busy for unhandled call {}", callId, e);
}
return;
}
var senderAddress = account.getRecipientAddressResolver()
.resolveRecipientAddress(senderId)
.toApiRecipientAddress();
@ -325,10 +339,16 @@ public class CallManager implements AutoCloseable {
}
public void handleIncomingHangup(final long callId) {
if (callEventListeners.isEmpty() && !activeCalls.containsKey(callId)) {
return;
}
endCall(callId, "remote_hangup");
}
public void handleIncomingBusy(final long callId) {
if (callEventListeners.isEmpty() && !activeCalls.containsKey(callId)) {
return;
}
endCall(callId, "remote_busy");
}