From ad8d692a136556895540bc92a9e7d3788b3b184e Mon Sep 17 00:00:00 2001 From: Shaheen Gandhi Date: Tue, 17 Mar 2026 16:08:20 -0700 Subject: [PATCH] Remove explicit success responses from hangup and reject commands Successful commands with no additional information should not return a response, matching the pattern used by other signal-cli commands like SendSyncRequestCommand and UpdateConfigurationCommand. Co-Authored-By: Claude Opus 4.6 (1M context) --- .../java/org/asamk/signal/commands/HangupCallCommand.java | 8 -------- .../java/org/asamk/signal/commands/RejectCallCommand.java | 8 -------- 2 files changed, 16 deletions(-) diff --git a/src/main/java/org/asamk/signal/commands/HangupCallCommand.java b/src/main/java/org/asamk/signal/commands/HangupCallCommand.java index 4254e073..5278d4d9 100644 --- a/src/main/java/org/asamk/signal/commands/HangupCallCommand.java +++ b/src/main/java/org/asamk/signal/commands/HangupCallCommand.java @@ -7,9 +7,7 @@ import org.asamk.signal.commands.exceptions.CommandException; import org.asamk.signal.commands.exceptions.IOErrorException; import org.asamk.signal.commands.exceptions.UserErrorException; import org.asamk.signal.manager.Manager; -import org.asamk.signal.output.JsonWriter; import org.asamk.signal.output.OutputWriter; -import org.asamk.signal.output.PlainTextWriter; import java.io.IOException; @@ -43,14 +41,8 @@ public class HangupCallCommand implements JsonRpcLocalCommand { try { m.hangupCall(callId); - switch (outputWriter) { - case PlainTextWriter writer -> writer.println("Call {} hung up.", callId); - case JsonWriter writer -> writer.write(new JsonResult(callId, "hung_up")); - } } catch (IOException e) { throw new IOErrorException("Failed to hang up call: " + e.getMessage(), e); } } - - private record JsonResult(long callId, String status) {} } diff --git a/src/main/java/org/asamk/signal/commands/RejectCallCommand.java b/src/main/java/org/asamk/signal/commands/RejectCallCommand.java index 85d1b7b4..cc730e57 100644 --- a/src/main/java/org/asamk/signal/commands/RejectCallCommand.java +++ b/src/main/java/org/asamk/signal/commands/RejectCallCommand.java @@ -7,9 +7,7 @@ import org.asamk.signal.commands.exceptions.CommandException; import org.asamk.signal.commands.exceptions.IOErrorException; import org.asamk.signal.commands.exceptions.UserErrorException; import org.asamk.signal.manager.Manager; -import org.asamk.signal.output.JsonWriter; import org.asamk.signal.output.OutputWriter; -import org.asamk.signal.output.PlainTextWriter; import java.io.IOException; @@ -43,14 +41,8 @@ public class RejectCallCommand implements JsonRpcLocalCommand { try { m.rejectCall(callId); - switch (outputWriter) { - case PlainTextWriter writer -> writer.println("Call {} rejected.", callId); - case JsonWriter writer -> writer.write(new JsonResult(callId, "rejected")); - } } catch (IOException e) { throw new IOErrorException("Failed to reject call: " + e.getMessage(), e); } } - - private record JsonResult(long callId, String status) {} }