nik/signal-cli
1
0
Fork 0
mirror of https://github.com/AsamK/signal-cli.git synced 2026-07-29 00:59:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update stubs for 3-parameter sendStory and add empty-recipient guard

Browse Source 
Updates DbusManagerImpl and StubManager (in SubscribeCallEventsTest) to
match the new 3-parameter sendStory signature: (String attachment,
boolean allowsReplies, Optional<GroupId> groupId).

Also includes the empty-recipient guard added after Task 1 review to
prevent stories from being sent to groups where the user is the only member.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MR2KF56Qcf9qNH1URj3XWs
This commit is contained in:
Tony Cebzanov 2026-07-09 10:31:32 -04:00
parent bb6dd85349
commit b95ca78593
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/src/main/java/org/asamk/signal/manager/internal/ManagerImpl.java
View File

@ -909,6 +909,10 @@ public class ManagerImpl implements Manager {
throw new IOException("Stories are only supported for V2 groups");
}
if (groupInfoV2.getMembersWithout(account.getSelfRecipientId()).isEmpty()) {
throw new IOException("No other members in group for story delivery");
}
final var uploadedAttachment = context.getAttachmentHelper().uploadAttachment(attachment);
final var groupContext = SignalServiceGroupV2.newBuilder(groupInfoV2.getMasterKey())
.withRevision(groupInfoV2.getGroup() == null ? 0 : groupInfoV2.getGroup().revision)

6
src/main/java/org/asamk/signal/dbus/DbusManagerImpl.java
View File

@ -548,7 +548,11 @@ public class DbusManagerImpl implements Manager {
}
@Override
public SendMessageResults sendStory(String attachment, boolean allowsReplies) {
public SendMessageResults sendStory(
String attachment,
boolean allowsReplies,
Optional<GroupId> groupId
) {
throw new UnsupportedOperationException();
}