nik/signal-cli
1
0
Fork 0
mirror of https://github.com/AsamK/signal-cli.git synced 2026-05-17 13:11:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use instanceof pattern matching for call ID extraction

Browse Source 
Replace explicit null check and Number cast with instanceof pattern
matching in AcceptCallCommand, HangupCallCommand, and
RejectCallCommand.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Shaheen Gandhi 2026-03-17 16:24:14 -07:00
parent ad8d692a13
commit cb7725482a
3 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/main/java/org/asamk/signal/commands/AcceptCallCommand.java
View File

@ -35,11 +35,10 @@ public class AcceptCallCommand implements JsonRpcLocalCommand {
final Manager m, final Manager m,
final OutputWriter outputWriter final OutputWriter outputWriter
) throws CommandException { ) throws CommandException {
final var callIdNumber = ns.get("call-id"); if (!(ns.get("call-id") instanceof Number callIdNumber)) {
if (callIdNumber == null) {
throw new UserErrorException("No call ID given"); throw new UserErrorException("No call ID given");
} }
final long callId = ((Number) callIdNumber).longValue(); final long callId = callIdNumber.longValue();
try { try {
var callInfo = m.acceptCall(callId); var callInfo = m.acceptCall(callId);

5
src/main/java/org/asamk/signal/commands/HangupCallCommand.java
View File

@ -33,11 +33,10 @@ public class HangupCallCommand implements JsonRpcLocalCommand {
final Manager m, final Manager m,
final OutputWriter outputWriter final OutputWriter outputWriter
) throws CommandException { ) throws CommandException {
final var callIdNumber = ns.get("call-id"); if (!(ns.get("call-id") instanceof Number callIdNumber)) {
if (callIdNumber == null) {
throw new UserErrorException("No call ID given"); throw new UserErrorException("No call ID given");
} }
final long callId = ((Number) callIdNumber).longValue(); final long callId = callIdNumber.longValue();
try { try {
m.hangupCall(callId); m.hangupCall(callId);

5
src/main/java/org/asamk/signal/commands/RejectCallCommand.java
View File

@ -33,11 +33,10 @@ public class RejectCallCommand implements JsonRpcLocalCommand {
final Manager m, final Manager m,
final OutputWriter outputWriter final OutputWriter outputWriter
) throws CommandException { ) throws CommandException {
final var callIdNumber = ns.get("call-id"); if (!(ns.get("call-id") instanceof Number callIdNumber)) {
if (callIdNumber == null) {
throw new UserErrorException("No call ID given"); throw new UserErrorException("No call ID given");
} }
final long callId = ((Number) callIdNumber).longValue(); final long callId = callIdNumber.longValue();
try { try {
m.rejectCall(callId); m.rejectCall(callId);