nik/signal-cli
1
0
Fork 0
mirror of https://github.com/AsamK/signal-cli.git synced 2026-05-02 10:41:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

enforce poll options between 1 and 100 characters; update documentation (#1965)

Browse Source 
pre-PR cleanup
This commit is contained in:
Zachary Johnson 2026-03-09 14:09:58 -04:00 committed by GitHub
parent b498d2050a
commit db0f660d08
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
man/signal-cli.1.adoc
View File

@ -443,6 +443,7 @@ By default, recipients can select multiple options.
*-o* OPTION [OPTION ...], *--option* OPTION [OPTION ...]*:: *-o* OPTION [OPTION ...], *--option* OPTION [OPTION ...]*::
The options for the poll. The options for the poll.
Between 2 and 10 options must be specified. Between 2 and 10 options must be specified.
Each option must be between 1 and 100 characters.
=== sendPollVote === sendPollVote

9
src/main/java/org/asamk/signal/commands/SendPollCreateCommand.java
View File

@ -25,6 +25,7 @@ public class SendPollCreateCommand implements JsonRpcLocalCommand {
private static final Logger logger = LoggerFactory.getLogger(SendPollCreateCommand.class); private static final Logger logger = LoggerFactory.getLogger(SendPollCreateCommand.class);
private static final int MAX_POLL_OPTIONS = 10; private static final int MAX_POLL_OPTIONS = 10;
private static final int MAX_POLL_OPTION_LENGTH = 100;
@Override @Override
public String getName() { public String getName() {
@ -76,6 +77,14 @@ public class SendPollCreateCommand implements JsonRpcLocalCommand {
if (options.size() > MAX_POLL_OPTIONS) { if (options.size() > MAX_POLL_OPTIONS) {
throw new UserErrorException("Poll cannot have more than " + MAX_POLL_OPTIONS + " options"); throw new UserErrorException("Poll cannot have more than " + MAX_POLL_OPTIONS + " options");
} }
for (final var option : options) {
if (option.isEmpty()) {
throw new UserErrorException("Poll options must not be empty");
}
if (option.length() > MAX_POLL_OPTION_LENGTH) {
throw new UserErrorException("Poll option \"" + option + "\" exceeds the maximum length of " + MAX_POLL_OPTION_LENGTH + " characters");
}
}
try { try {
var results = m.sendPollCreateMessage(question, !noMulti, options, recipientIdentifiers, notifySelf); var results = m.sendPollCreateMessage(question, !noMulti, options, recipientIdentifiers, notifySelf);